[GitHub] [pulsar] merlimat commented on a change in pull request #9292: [pulsar-broker] Support large number of unack message store for cursor recovery

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #9292:
URL: https://github.com/apache/pulsar/pull/9292#discussion_r563328917



##########
File path: managed-ledger/src/main/proto/MLDataFormats.proto
##########
@@ -71,6 +71,9 @@ message PositionInfo {
 
     // Store which index in the batch message has been deleted
     repeated BatchedEntryDeletionIndexInfo batchedEntryDeletionIndexInfo = 5;
+
+    // serialized individualDeletedMessages
+    optional bytes serializedIndividualDeletedMessages = 6;

Review comment:
       Instead of having a byte array here, I think it would be better to have instead a way to encode the range set in protobuf directly




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org