[jira] [Comment Edited] (HUDI-233) Redo log statements using {} variable substitution

["Vinoth Chandar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HUDI-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921110#comment-16921110 ] 

Vinoth Chandar edited comment on HUDI-233 at 9/3/19 2:18 AM:
-------------------------------------------------------------

Just got the PR up for new bundling. Relevant detail is that we no longer have slf4j. Most of the code was doing log4j directly and I just standardized on that.  

BTW sure log4j does not support this? What do Hive/Spark/Presto do for logging. We need to consider what plays nicely with them and the bundles.. With slf4j its easy to have multiple logging impl thrown into classpath and end up with jar/pom munging to make logging work. 


was (Author: vc):
Just got the PR up for new bundling. BTW sure log4j does not support this? 

> Redo log statements using {} variable substitution
> --------------------------------------------------
>
>                 Key: HUDI-233
>                 URL: https://issues.apache.org/jira/browse/HUDI-233
>             Project: Apache Hudi (incubating)
>          Issue Type: Bug
>          Components: newbie, Performance
>    Affects Versions: 0.5.0
>            Reporter: Vinoth Chandar
>            Assignee: leesf
>            Priority: Major
>
> Currently we are not employing variable substitution aggresively in the project.  ala 
> {code:java}
> LogManager.getLogger(SomeName.class.getName()).info("Message: {}, Detail: {}", message, detail);
> {code}
> This can improve performance since the string concatenation is deferrable to when the logging is actually in effect.  



--
This message was sent by Atlassian Jira
(v8.3.2#803003)