[GitHub] [flink] ambition119 edited a comment on issue #8387: [FLINK-11982] [table] File System Connector's support JSON Format and JSON file BatchTableSource

[GitBox <gi...@apache.org>]

ambition119 edited a comment on issue #8387: [FLINK-11982] [table] File System Connector's support JSON Format and JSON file BatchTableSource
URL: https://github.com/apache/flink/pull/8387#issuecomment-491243931
 
 
   > In this PR, the format "JSON" and the connector "file" are mixed into one aspect.
   > 
   > In the design for sources, we want to keep format and connector separate, so they can be combined (i.e., combine file with Avro, combine Kafka with JSON, etc.).
   > The way to support JSON files would be to combine the "file" Connector with the Json Format.
   > 
   > There is also a [flink-json](https://github.com/apache/flink/tree/master/flink-formats/flink-json) module already.
   > 
   > Does that approach currently not work?
   > 
   > @twalthr or @dawidwys Could you share some details here?
   
   yes , I dev also use [flink-json module](https://github.com/apache/flink/blob/c1b8f6757cee56ee9744f0533d2ec0118ef82801/flink-connectors/flink-connector-json/pom.xml#L77) like [JsonRowDeserializationSchema](https://github.com/apache/flink/blob/c1b8f6757cee56ee9744f0533d2ec0118ef82801/flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDeserializationSchema.java) in JsonRowInputFormat.
   
   But [org.apache.flink.formats.json.JsonRowFormatFactory](https://github.com/apache/flink/blob/c1b8f6757cee56ee9744f0533d2ec0118ef82801/flink-formats/flink-json/src/main/resources/META-INF/services/org.apache.flink.table.factories.TableFactory) not support File System Connector [ISSUE #11982](https://issues.apache.org/jira/browse/FLINK-11982), so dev JsonBatchTableSourceFactory  and JsonBatchTableSource.  
   
   In fact, at first I wanted to add  classes in flink-json module, considering the mature use of this module, then add the flink-connector-json module. 
   
   This implementation has been validated and run for a while in our flink production environment. thanks. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services