[jira] [Commented] (THRIFT-1530) thrift c_glib code has no support for timeouts

["Gonzalo Aguilar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620830#comment-14620830 ] 

Gonzalo Aguilar commented on THRIFT-1530:
-----------------------------------------

Hi, 
I don't understand this part of the patch:

-    ret = recv (socket->sd, buf+got, len-got, 0);
+    ret = recv (socket->sd, buf, len, 0);

Because for me your patch will not work if you apply that then data will be overwritten in the buffer

> thrift c_glib code has no support for timeouts
> ----------------------------------------------
>
>                 Key: THRIFT-1530
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1530
>             Project: Thrift
>          Issue Type: Bug
>          Components: C glib - Compiler, C glib - Library
>    Affects Versions: 0.8, 0.9
>            Reporter: Mina Naguib
>              Labels: c, c_glib, glib, out, thrift, time, timeout
>         Attachments: thrift-c-glib-with-timeout.patch
>
>
> There's no mention of "timeout" anywhere in the c_glib compiler's code, nor (obviously) in the generated gen-c_glib code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)