You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2021/03/07 15:09:29 UTC

[hbase] branch HBASE-25604 created (now a058686)

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a change to branch HBASE-25604
in repository https://gitbox.apache.org/repos/asf/hbase.git.


      at a058686  HBASE-25604 Upgrade spotbugs to 4.x

This branch includes the following new commits:

     new a058686  HBASE-25604 Upgrade spotbugs to 4.x

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[hbase] 01/01: HBASE-25604 Upgrade spotbugs to 4.x

Posted by zh...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch HBASE-25604
in repository https://gitbox.apache.org/repos/asf/hbase.git

commit a058686339bcc0f9da2299a131e221d798c04b3e
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Sun Mar 7 23:08:14 2021 +0800

    HBASE-25604 Upgrade spotbugs to 4.x
---
 dev-support/docker/Dockerfile |  5 +++--
 pom.xml                       | 12 ++++++++++--
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/dev-support/docker/Dockerfile b/dev-support/docker/Dockerfile
index f8bcd08..2be3452 100644
--- a/dev-support/docker/Dockerfile
+++ b/dev-support/docker/Dockerfile
@@ -73,9 +73,9 @@ ENV LANG=en_US.UTF-8 LANGUAGE=en_US:en LC_ALL=en_US.UTF-8
 #
 
 FROM BASE_IMAGE AS SPOTBUGS_DOWNLOAD_IMAGE
-ENV SPOTBUGS_VERSION '3.1.12'
+ENV SPOTBUGS_VERSION '4.2.2'
 ENV SPOTBUGS_URL "https://repo.maven.apache.org/maven2/com/github/spotbugs/spotbugs/${SPOTBUGS_VERSION}/spotbugs-${SPOTBUGS_VERSION}.tgz"
-ENV SPOTBUGS_SHA256 '9c475d6c7096ed7af783e04dc2db40462145291de75a80029391600b6eb2d401'
+ENV SPOTBUGS_SHA256 '4967c72396e34b86b9458d0c34c5ed185770a009d357df8e63951ee2844f769f'
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 RUN curl --location --fail --silent --show-error --output /tmp/spotbugs.tgz "${SPOTBUGS_URL}" && \
   echo "${SPOTBUGS_SHA256} */tmp/spotbugs.tgz" | sha256sum -c -
@@ -128,6 +128,7 @@ SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 COPY --from=SPOTBUGS_DOWNLOAD_IMAGE /tmp/spotbugs.tgz /tmp/spotbugs.tgz
 RUN tar xzf /tmp/spotbugs.tgz -C /opt && \
   ln -s "/opt/$(tar -tf /tmp/spotbugs.tgz | head -n1 | cut -d/ -f1)" /opt/spotbugs && \
+  chmod -R a+x /opt/spotbugs/bin/* && \
   rm /tmp/spotbugs.tgz
 
 COPY --from=HADOLINT_DOWNLOAD_IMAGE /tmp/hadolint /tmp/hadolint
diff --git a/pom.xml b/pom.xml
index fd792f9..2358544 100755
--- a/pom.xml
+++ b/pom.xml
@@ -827,6 +827,14 @@
             <xmlOutput>true</xmlOutput>
             <effort>Max</effort>
           </configuration>
+          <dependencies>
+          <!-- overwrite dependency on spotbugs if you want to specify the version of spotbugs -->
+            <dependency>
+              <groupId>com.github.spotbugs</groupId>
+              <artifactId>spotbugs</artifactId>
+              <version>${spotbugs.version}</version>
+            </dependency>
+          </dependencies>
         </plugin>
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
@@ -1686,8 +1694,8 @@
     <maven.project.info.report.version>2.9</maven.project.info.report.version>
     <os.maven.version>1.5.0.Final</os.maven.version>
     <findbugs-annotations.version>1.3.9-1</findbugs-annotations.version>
-    <spotbugs.version>3.1.12</spotbugs.version>
-    <spotbugs.maven.version>3.1.12.2</spotbugs.maven.version>
+    <spotbugs.version>4.2.2</spotbugs.version>
+    <spotbugs.maven.version>4.2.0</spotbugs.maven.version>
     <surefire.version>3.0.0-M4</surefire.version>
     <wagon.ssh.version>2.12</wagon.ssh.version>
     <xml.maven.version>1.0.1</xml.maven.version>