You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2011/06/21 22:51:47 UTC
[jira] [Created] (CASSANDRA-2806) Expose gossip/FD info to JMX
Expose gossip/FD info to JMX
----------------------------
Key: CASSANDRA-2806
URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
Project: Cassandra
Issue Type: Improvement
Reporter: Brandon Williams
Assignee: Brandon Williams
Priority: Minor
Fix For: 0.8.2
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083264#comment-13083264 ]
Jonathan Ellis commented on CASSANDRA-2806:
-------------------------------------------
So for FD it is obvious what to expose, just a Map of up/down.
What should we expose for gossip? Map of ApplicationState?
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Minor
> Fix For: 0.8.5
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085918#comment-13085918 ]
Brandon Williams commented on CASSANDRA-2806:
---------------------------------------------
I don't see a way to force eviction with this patch.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085947#comment-13085947 ]
Brandon Williams commented on CASSANDRA-2806:
---------------------------------------------
We need the custom quarantine time, otherwise it's going to be difficult to make it useful (invoke it on all machines in under the standard quarantine time is doable, but not easy)
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patricio Echague updated CASSANDRA-2806:
----------------------------------------
Attachment: CASSANDRA-2806-0.8-v3.patch
Here you go.
-Removed evictEndpoint
- Also organize imports in Gossiper that originally were not respecting the Code Style.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, CASSANDRA-2806-0.8-v3.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085348#comment-13085348 ]
Brandon Williams commented on CASSANDRA-2806:
---------------------------------------------
In the gossiper, we also need to expose the following op:
* Forced quarantine/eviction of an IP address, possibly taking a parameter to define how long to quarantine it for.
This way in the rare event that someone does break CASSANDRA-1730, they can fix it without full ring restarts, avoid other full ring restart situations. This shouldn't be exposed in nodetool though because it can easily be dangerous.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-v1.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083850#comment-13083850 ]
Patricio Echague commented on CASSANDRA-2806:
---------------------------------------------
For Gossiper, although some info such as ApplicationState is exposed through FD, I propose:
- getVersion(String nodeAddress)
- getEndpointDowntime(String nodeAddress)
- getCurrentGenerationNumber(String nodeAddress)
Comments?
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patricio Echague updated CASSANDRA-2806:
----------------------------------------
Attachment: CASSANDRA-2806-0.8-v2.patch
v2 replaces v1
- Add GossiperMBean with its implementation.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patricio Echague updated CASSANDRA-2806:
----------------------------------------
Attachment: CASSANDRA-2806-0.8-v4.patch
This patches replaces all previous including the one for CHANGES.txt.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, CASSANDRA-2806-0.8-v3.patch, CASSANDRA-2806-0.8-v4.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patricio Echague updated CASSANDRA-2806:
----------------------------------------
Attachment: screenshot-1.jpg
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-2806:
----------------------------------------
Reviewer: brandon.williams
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-v1.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083758#comment-13083758 ]
Patricio Echague commented on CASSANDRA-2806:
---------------------------------------------
What does everyone prefer ?
1)
{code}
{
UP : Node1, Node2, Node3
DOWN : Node4
}
{code}
2)
{code}
{
Node1 : UP
Node2 : UP
Node3 : DOWN
}
{code}
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-2806:
-----------------------------------------
Assignee: Patricio Echague (was: Brandon Williams)
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085925#comment-13085925 ]
Patricio Echague commented on CASSANDRA-2806:
---------------------------------------------
Doesn't evictEndpoint(String address) work as expected?
I used the same logic that doStatusCheck() uses to evict an endpoint.
If that is not right, please advice.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patricio Echague updated CASSANDRA-2806:
----------------------------------------
Attachment: CASSANDRA-2806-0.8-v1.patch
This patch addresses the info for FD only.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-v1.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patricio Echague updated CASSANDRA-2806:
----------------------------------------
Attachment: CASSANDRA-2806-0.8-CHANGES.patch
Add description and ticket number in CHANGES.txt
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087811#comment-13087811 ]
Brandon Williams commented on CASSANDRA-2806:
---------------------------------------------
Argh, it applied when I tested but failed a hunk when I went to commit after pulling, can you rebase please? Otherwise looks good.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, CASSANDRA-2806-0.8-v3.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Patricio Echague (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083844#comment-13083844 ]
Patricio Echague commented on CASSANDRA-2806:
---------------------------------------------
Also added -> nodetool gossipinfo
{code}
patricioe:cassandra-0.8 patricioe$ bin/nodetool -h 127.0.0.3 -p 7300 gossipinfo
/127.0.0.2
STATUS:NORMAL,129522978513606330061876529562911371393
RPC_ADDRESS:/127.0.0.2
LOAD:1.10768421E8
RELEASE_VERSION:0.8.2-dev-SNAPSHOT
SCHEMA:46882900-bfb1-11e0-0000-7fd66bb03aff
/127.0.0.3
STATUS:NORMAL,124888331406072459946803385462097037262
RPC_ADDRESS:/127.0.0.3
LOAD:4.0371818E7
RELEASE_VERSION:0.8.2-dev-SNAPSHOT
SCHEMA:46882900-bfb1-11e0-0000-7fd66bb03aff
/127.0.0.4
STATUS:NORMAL,44629256491637497965682179905983472419
RPC_ADDRESS:/127.0.0.4
LOAD:31056.0
RELEASE_VERSION:0.8.2-dev-SNAPSHOT
SCHEMA:46882900-bfb1-11e0-0000-7fd66bb03aff
{code}
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093764#comment-13093764 ]
Hudson commented on CASSANDRA-2806:
-----------------------------------
Integrated in Cassandra #1056 (See [https://builds.apache.org/job/Cassandra/1056/])
Expose gossip/FD info to JMX
patch by Patricio Echague; reviewed by brandonwilliams for CASSANDRA-2806
jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1163201
Files :
* /cassandra/trunk/CHANGES.txt
* /cassandra/trunk/src/java/org/apache/cassandra/gms/FailureDetector.java
* /cassandra/trunk/src/java/org/apache/cassandra/gms/FailureDetectorMBean.java
* /cassandra/trunk/src/java/org/apache/cassandra/gms/Gossiper.java
* /cassandra/trunk/src/java/org/apache/cassandra/tools/NodeCmd.java
* /cassandra/trunk/src/java/org/apache/cassandra/tools/NodeProbe.java
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 1.0
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, CASSANDRA-2806-0.8-v3.patch, CASSANDRA-2806-0.8-v4.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2806) Expose gossip/FD info to JMX
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086597#comment-13086597 ]
Brandon Williams commented on CASSANDRA-2806:
---------------------------------------------
After thinking this through a bit more, I think for this ticket, we should just remove the ability to evict a host and make a new ticket for that. The reason being is that evicting a member of the ring is more complicated, since the StorageService needs to be notified to update the TokenMetadata in case the host is a member of the ring.
> Expose gossip/FD info to JMX
> ----------------------------
>
> Key: CASSANDRA-2806
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2806
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Brandon Williams
> Assignee: Patricio Echague
> Priority: Minor
> Fix For: 0.8.5
>
> Attachments: CASSANDRA-2806-0.8-CHANGES.patch, CASSANDRA-2806-0.8-v1.patch, CASSANDRA-2806-0.8-v2.patch, screenshot-1.jpg
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira