You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/11/08 22:47:35 UTC
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11913
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
IMPALA-7840: add missing error to test_concurrent_schema_change
test_concurrent_schema_change runs a series of alters and inserts on
the same Kudu table concurrently to ensure that Impala can handle this
without crashing.
There is a list of expected error messages in the test. One possible
legitimate error is missing, causing the test to sometimes be flaky.
This patch adds that error message to the test.
Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
---
M tests/query_test/test_kudu.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/11913/1
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Fri, 09 Nov 2018 03:23:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 15 Nov 2018 03:09:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1339/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:38:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11913/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/11913/1/tests/query_test/test_kudu.py@448
PS1, Line 448: "Client provided column col1 INT64 NULLABLE not present in tablet" ,
> It's fine as is, but as a nit, an improvement might be to assert something
Done
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:17:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1340/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:49:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 3: Code-Review+2
carrying forward
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:21:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@443
PS2, Line 443: ,
> flake8: E203 whitespace before ','
Done
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@444
PS2, Line 444: ,
> flake8: E203 whitespace before ','
Done
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@445
PS2, Line 445: ,
> flake8: E203 whitespace before ','
Done
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@446
PS2, Line 446: ,
> flake8: E203 whitespace before ','
Done
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@447
PS2, Line 447: ,
> flake8: E203 whitespace before ','
Done
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@448
PS2, Line 448: ,
> flake8: E203 whitespace before ','
Done
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:21:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
IMPALA-7840: add missing error to test_concurrent_schema_change
test_concurrent_schema_change runs a series of alters and inserts on
the same Kudu table concurrently to ensure that Impala can handle this
without crashing.
There is a list of expected error messages in the test. One possible
legitimate error is missing, causing the test to sometimes be flaky.
This patch adds that error message to the test.
Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Reviewed-on: http://gerrit.cloudera.org:8080/11913
Reviewed-by: Thomas Marshall <th...@cmu.edu>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_kudu.py
1 file changed, 11 insertions(+), 7 deletions(-)
Approvals:
Thomas Marshall: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@443
PS2, Line 443:
flake8: E203 whitespace before ','
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@444
PS2, Line 444:
flake8: E203 whitespace before ','
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@445
PS2, Line 445:
flake8: E203 whitespace before ','
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@446
PS2, Line 446:
flake8: E203 whitespace before ','
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@447
PS2, Line 447:
flake8: E203 whitespace before ','
http://gerrit.cloudera.org:8080/#/c/11913/2/tests/query_test/test_kudu.py@448
PS2, Line 448:
flake8: E203 whitespace before ','
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:17:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
It's fine as is, but as a nit, an improvement might be to assert something like:
possible_errors = [
"has fewer columns (1) than the SELECT / VALUES clause returns (2)",
"(type: TINYINT) is not compatible with column 'col1' (type: STRING)",
"has fewer columns than expected.",
"Column col1 has unexpected type.",
"Client provided column col1[int64 NULLABLE] not present in tablet",
"Client provided column col1 INT64 NULLABLE not present in tablet",
"The column 'col1' must have type string NULLABLE found int64 NULLABLE"
]
# As long as one of the possible errors is in the message, assert should pass
assert any(err in msg for err in possible_errors)
http://gerrit.cloudera.org:8080/#/c/11913/1/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:
http://gerrit.cloudera.org:8080/#/c/11913/1/tests/query_test/test_kudu.py@448
PS1, Line 448: or "The column 'col1' must have type string NULLABLE found int64 NULLABLE" in msg
It's fine as is, but as a nit, an improvement might be to assert something like:
possible_errors = [
"has fewer columns (1) than the SELECT / VALUES clause returns (2)",
"(type: TINYINT) is not compatible with column 'col1' (type: STRING)",
"has fewer columns than expected.",
"Column col1 has unexpected type.",
"Client provided column col1[int64 NULLABLE] not present in tablet",
"Client provided column col1 INT64 NULLABLE not present in tablet",
"The column 'col1' must have type string NULLABLE found int64 NULLABLE"
]
# As long as one of the possible errors is in the message, assert should pass
assert any(err in msg for err in possible_errors)
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:00:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello David Knupp, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11913
to look at the new patch set (#2).
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
IMPALA-7840: add missing error to test_concurrent_schema_change
test_concurrent_schema_change runs a series of alters and inserts on
the same Kudu table concurrently to ensure that Impala can handle this
without crashing.
There is a list of expected error messages in the test. One possible
legitimate error is missing, causing the test to sometimes be flaky.
This patch adds that error message to the test.
Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
---
M tests/query_test/test_kudu.py
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/11913/2
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello David Knupp, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11913
to look at the new patch set (#3).
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
IMPALA-7840: add missing error to test_concurrent_schema_change
test_concurrent_schema_change runs a series of alters and inserts on
the same Kudu table concurrently to ensure that Impala can handle this
without crashing.
There is a list of expected error messages in the test. One possible
legitimate error is missing, causing the test to sometimes be flaky.
This patch adds that error message to the test.
Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
---
M tests/query_test/test_kudu.py
1 file changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/13/11913/3
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1337/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:31:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7840: add missing error to test concurrent schema change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11913 )
Change subject: IMPALA-7840: add missing error to test_concurrent_schema_change
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3446/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc01e1244e05be30343c05b5a0f8676f4d4603d2
Gerrit-Change-Number: 11913
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 23:22:31 +0000
Gerrit-HasComments: No