You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/07/06 06:59:58 UTC
[GitHub] [tomcat] martin-g commented on a change in pull request #316: Use lowercase HTML tags and attributes. Add quotes around attributes.
martin-g commented on a change in pull request #316:
URL: https://github.com/apache/tomcat/pull/316#discussion_r450018806
##########
File path: webapps/ROOT/index.jsp
##########
@@ -25,11 +25,11 @@ request.setAttribute("tomcatExamplesUrl", "/examples/");
<!DOCTYPE html>
<html lang="en">
<head>
- <meta charset="UTF-8" />
+ <meta charset="UTF-8">
Review comment:
Why did you remove the auto-closing ? It doesn't do any harm. I, personally, prefer the style it was before.
##########
File path: webapps/examples/jsp/cal/cal2.jsp
##########
@@ -15,31 +15,30 @@
limitations under the License.
--%>
<%@page contentType="text/html; charset=UTF-8" %>
-<HTML>
-<HEAD><TITLE>
- Calendar: A JSP APPLICATION
-</TITLE></HEAD>
+<html>
+<head>
+<title>Calendar: A JSP APPLICATION</title>
+</head>
-
-<BODY BGCOLOR="white">
+<body bgcolor="white">
<jsp:useBean id="table" scope="session" class="cal.TableBean" />
<%
String time = request.getParameter ("time");
%>
-<FONT SIZE=5> Please add the following event:
-<BR> <h3> Date <%= table.getDate() %>
-<BR> Time <%= util.HTMLFilter.filter(time) %> </h3>
-</FONT>
-<FORM METHOD=POST ACTION=cal1.jsp>
-<BR>
-<BR> <INPUT NAME="date" TYPE=HIDDEN VALUE="current">
-<BR> <INPUT NAME="time" TYPE=HIDDEN VALUE="<%= util.HTMLFilter.filter(time) %>">
-<BR> <h2> Description of the event <INPUT NAME="description" TYPE=TEXT SIZE=20> </h2>
-<BR> <INPUT TYPE=SUBMIT VALUE="submit">
-</FORM>
-
-</BODY>
-</HTML>
+<font size="5"> Please add the following event:
+<br> <h3> Date <%= table.getDate() %>
Review comment:
indentation
##########
File path: webapps/examples/jsp/cal/cal1.jsp
##########
@@ -32,63 +31,60 @@
%>
<!-- html table goes here -->
-<CENTER>
-<TABLE WIDTH=60% BGCOLOR=yellow CELLPADDING=15>
-<TR>
-<TD ALIGN=CENTER> <A HREF=cal1.jsp?date=prev> prev </A>
-<TD ALIGN=CENTER> Calendar:<%= table.getDate() %></TD>
-<TD ALIGN=CENTER> <A HREF=cal1.jsp?date=next> next </A>
-</TR>
-</TABLE>
+<center>
+<table width="60%" bgcolor="yellow" cellpadding="15">
+<tr>
+<td align="center"> <a href="cal1.jsp?date=prev"> prev </a>
+<td align="center"> Calendar:<%= table.getDate() %></td>
+<td align="center"> <a href="cal1.jsp?date=next"> next </a>
Review comment:
no indentation
##########
File path: webapps/examples/jsp/cal/cal1.jsp
##########
@@ -15,13 +15,12 @@
limitations under the License.
--%>
<%@page contentType="text/html; charset=UTF-8" %>
-<HTML>
-<HEAD><TITLE>
- Calendar: A JSP APPLICATION
-</TITLE></HEAD>
+<html>
+<head>
+<title>Calendar: A JSP APPLICATION</title>
Review comment:
There is no indentation here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org