You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@roller.apache.org by "Kohei Nozaki (JIRA)" <ji...@apache.org> on 2016/10/23 07:47:58 UTC

[jira] [Resolved] (ROL-2101) Thread unsafe use of HashMap for cached mappings exist

     [ https://issues.apache.org/jira/browse/ROL-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kohei Nozaki resolved ROL-2101.
-------------------------------
    Resolution: Fixed

The fix merged to master https://github.com/apache/roller/pull/5

> Thread unsafe use of HashMap for cached mappings exist
> ------------------------------------------------------
>
>                 Key: ROL-2101
>                 URL: https://issues.apache.org/jira/browse/ROL-2101
>             Project: Apache Roller
>          Issue Type: Bug
>          Components: Data Model & JPA Backend
>    Affects Versions: 5.1.2
>            Reporter: Kohei Nozaki
>            Assignee: Roller Unassigned
>            Priority: Minor
>         Attachments: ROL-2101.patch
>
>
> There are two singleton classes that have a instance field type of {{HashMap}} for cache.
> In {{JPAUserManagerImpl}}:
> {noformat}
> // cached mapping of userNames -> userIds
> private Map<String, String> userNameToIdMap = new HashMap<String, String>();
> {noformat}
> In {{JPAWeblogEntryManagerImpl}}:
> {noformat}
> // cached mapping of entryAnchors -> entryIds
> private Map<String, String> entryAnchorToIdMap = new HashMap<String, String>();
> {noformat}
> {{HashMap}} s should not be used as the above because it's not thread safe.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)