[jira] [Created] (SLING-4390) webapp deployment: properties in sling.properties overrule web.xml init parameters

["Jörg Hoh (JIRA)" <ji...@apache.org>]

Jörg Hoh created SLING-4390:
-------------------------------

             Summary: webapp deployment: properties in sling.properties overrule web.xml init parameters
                 Key: SLING-4390
                 URL: https://issues.apache.org/jira/browse/SLING-4390
             Project: Sling
          Issue Type: Bug
          Components: Launchpad
    Affects Versions: Launchpad Base 2.5.6
            Reporter: Jörg Hoh


The documentation [1] explictly states, that any parameter in the web.xml will overwrite the variable with the same in sling.properties.

But looking at the code in Sling.java, I find, that into the init() method the parameters from the web.xml are passed in via the propOverwrite map. This map is first applied, and then the sling.properties (if available) is read and applied.
This violates both the documentation on site [1] and also the javadoc of the class.

The impact can be rather huge, as it isn't possible to update parameters which are stored in the sling.properties already with a new version of the web,xml contained in the WAR file. But we need to update the sling.properties file manually.




[1] http://sling.apache.org/documentation/the-sling-engine/the-sling-launchpad.html#servlet-parameters




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)