You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/03 12:59:14 UTC

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a change in pull request #57: Add measure and topN APIs

lujiajing1126 commented on a change in pull request #57:
URL: https://github.com/apache/skywalking-banyandb/pull/57#discussion_r741899656



##########
File path: api/proto/banyandb/measure/v1/query.proto
##########
@@ -55,21 +55,17 @@ message QueryRequest {
   model.v1.TimeRange time_range = 2;
   // offset is used to support pagination, together with the following limit
   uint32 offset = 3;

Review comment:
       offset should also be remove?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org