You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/06 07:54:08 UTC
[GitHub] [pulsar] vzhikserg opened a new pull request #6888: [functions] Fix validation of function's update
vzhikserg opened a new pull request #6888:
URL: https://github.com/apache/pulsar/pull/6888
### Motivation
The validation of parameters for function's update was not properly implemented for the outputSerdeClassName parameter. It was checking the outputSchemaType field instead.
### Modifications
Updated the if conditions and added tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6888: [functions] Fix validation of function's update
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6888:
URL: https://github.com/apache/pulsar/pull/6888#issuecomment-624547292
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #6888: [functions] Fix validation of function's update
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #6888:
URL: https://github.com/apache/pulsar/pull/6888#issuecomment-625091280
@vzhikserg Nice catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6888: [functions] Fix validation of function's update
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6888:
URL: https://github.com/apache/pulsar/pull/6888#issuecomment-624599685
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] vzhikserg commented on pull request #6888: [functions] Fix validation of function's update
Posted by GitBox <gi...@apache.org>.
vzhikserg commented on pull request #6888:
URL: https://github.com/apache/pulsar/pull/6888#issuecomment-624584053
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org