You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by mi...@apache.org on 2023/11/20 07:09:38 UTC
(incubator-devlake) 01/01: fix(config-ui): style error for connection name
This is an automated email from the ASF dual-hosted git repository.
mintsweet pushed a commit to branch release-v0.20-fix-6481
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit 16a68020138e03c5a5c3ce7a7a6344f734eb0c35
Author: mintsweet <0x...@gmail.com>
AuthorDate: Mon Nov 20 20:09:21 2023 +1300
fix(config-ui): style error for connection name
---
config-ui/src/pages/blueprint/home/index.tsx | 12 ++++--------
config-ui/src/pages/blueprint/home/styled.ts | 16 ----------------
config-ui/src/pages/project/home/index.tsx | 12 ++++--------
config-ui/src/pages/project/home/styled.ts | 16 ----------------
4 files changed, 8 insertions(+), 48 deletions(-)
diff --git a/config-ui/src/pages/blueprint/home/index.tsx b/config-ui/src/pages/blueprint/home/index.tsx
index 8f65246f0..59cac8095 100644
--- a/config-ui/src/pages/blueprint/home/index.tsx
+++ b/config-ui/src/pages/blueprint/home/index.tsx
@@ -132,17 +132,13 @@ export const BlueprintHomePage = () => {
return 'Advanced Mode';
}
return (
- <S.ConnectionList>
+ <ul>
{connections.map((it) => (
- <li>
- <ConnectionName
- key={`${it.pluginName}-${it.connectionId}`}
- plugin={it.pluginName}
- connectionId={it.connectionId}
- />
+ <li key={`${it.pluginName}-${it.connectionId}`}>
+ <ConnectionName plugin={it.pluginName} connectionId={it.connectionId} />
</li>
))}
- </S.ConnectionList>
+ </ul>
);
},
},
diff --git a/config-ui/src/pages/blueprint/home/styled.ts b/config-ui/src/pages/blueprint/home/styled.ts
index d81cd2b51..99ee9eaf5 100644
--- a/config-ui/src/pages/blueprint/home/styled.ts
+++ b/config-ui/src/pages/blueprint/home/styled.ts
@@ -46,19 +46,3 @@ export const LabelInfo = styled.i`
export const LabelDescription = styled.p`
margin: 0;
`;
-
-export const ConnectionList = styled.ul`
- display: flex;
-
- li {
- &:last-child {
- &::after {
- content: '';
- }
- }
-
- &::after {
- content: ',';
- }
- }
-`;
diff --git a/config-ui/src/pages/project/home/index.tsx b/config-ui/src/pages/project/home/index.tsx
index 5f1e2f06a..abdd60c86 100644
--- a/config-ui/src/pages/project/home/index.tsx
+++ b/config-ui/src/pages/project/home/index.tsx
@@ -142,17 +142,13 @@ export const ProjectHomePage = () => {
!val || !val.length ? (
'N/A'
) : (
- <S.ConnectionList>
+ <ul>
{val.map((it) => (
- <li>
- <ConnectionName
- key={`${it.pluginName}-${it.connectionId}`}
- plugin={it.pluginName}
- connectionId={it.connectionId}
- />
+ <li key={`${it.pluginName}-${it.connectionId}`}>
+ <ConnectionName plugin={it.pluginName} connectionId={it.connectionId} />
</li>
))}
- </S.ConnectionList>
+ </ul>
),
},
{
diff --git a/config-ui/src/pages/project/home/styled.ts b/config-ui/src/pages/project/home/styled.ts
index 5e5a50db6..86e2c5568 100644
--- a/config-ui/src/pages/project/home/styled.ts
+++ b/config-ui/src/pages/project/home/styled.ts
@@ -37,19 +37,3 @@ export const LabelInfo = styled.i`
export const LabelDescription = styled.p`
margin: 0;
`;
-
-export const ConnectionList = styled.ul`
- display: flex;
-
- li {
- &:last-child {
- &::after {
- content: '';
- }
- }
-
- &::after {
- content: ',';
- }
- }
-`;