You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Stefan Sperling <st...@elego.de> on 2010/05/03 14:20:48 UTC

Re: svn commit: r937275 - in /subversion/trunk/subversion: include/svn_subst.h libsvn_subr/subst.c

On Mon, Apr 26, 2010 at 11:40:41AM -0400, Greg Stein wrote:
> On Mon, Apr 26, 2010 at 06:54, Julian Foad <ju...@wandisco.com> wrote:
> > On Fri, 2010-04-23, Stefan Sperling wrote:
> >> On Fri, Apr 23, 2010 at 01:01:24PM -0000, stsp@apache.org wrote:
> >...
> >> > +++ subversion/trunk/subversion/include/svn_subst.h Fri Apr 23 13:01:23 2010
> >> > @@ -301,7 +301,9 @@ svn_subst_translate_stream(svn_stream_t
> >> >   * if @a repair is @c TRUE, convert any line ending to @a eol_str.
> >> >   * Recognized line endings are: "\n", "\r", and "\r\n".
> >> >   *
> >> > - * The stream returned is allocated in @a pool.
> >> > + * The stream returned is allocated in @a result_pool.
> >> > + * @a eol_str and @a keywords are expected to be allocated in a pool
> >> > + * with sufficient lifetime for use by the stream.
> >
> > It seems to me that adding this requirement now is unsafe, because our
> > API users would not expect this.  I think it would be best to revert
> > that part of the change, restoring the code that copies EOL_STR and
> > KEYWORDS into what is now RESULT_POOL.
> 
> Yup. My thoughts exactly.

Done in r940429.

Stefan