You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/15 11:54:42 UTC

[GitHub] [tvm] mbaret opened a new pull request, #13392: [AOT][FIX] Handle device contexts properly in CreateFunctionMetadata

mbaret opened a new pull request, #13392:
URL: https://github.com/apache/tvm/pull/13392

   Device contexts created handles with no corresponding buffer which would confuse CreateFunctionMetadata causing a segfault. The logic has been changed to check that a buffer exists and a test updated to include this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] mbaret commented on pull request #13392: [AOT][FIX] Handle device contexts properly in CreateFunctionMetadata

Posted by GitBox <gi...@apache.org>.
mbaret commented on PR #13392:
URL: https://github.com/apache/tvm/pull/13392#issuecomment-1315205066

   cc @ekalda 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tmoreau89 merged pull request #13392: [AOT][FIX] Handle device contexts properly in CreateFunctionMetadata

Posted by GitBox <gi...@apache.org>.
tmoreau89 merged PR #13392:
URL: https://github.com/apache/tvm/pull/13392


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #13392: [AOT][FIX] Handle device contexts properly in CreateFunctionMetadata

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13392:
URL: https://github.com/apache/tvm/pull/13392#issuecomment-1315204460

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Mousius, @alanmacd, @areusch, @lhutton1 <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tmoreau89 commented on pull request #13392: [AOT][FIX] Handle device contexts properly in CreateFunctionMetadata

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on PR #13392:
URL: https://github.com/apache/tvm/pull/13392#issuecomment-1315820742

   Thanks @mbaret @Mousius the PR has been merged
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org