You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openwebbeans.apache.org by Thomas Andraschko <zo...@gmail.com> on 2012/08/31 11:07:29 UTC

Rework logger API (OWB-674) breaks failover/serialization

Hi,

AFAICS the old WebBeansLogger was serializable and JUL isn't.
This breaks again the failover because OWB has some or many non-static
loggers. It's really annoying because since 1.1.3, every version destroyed
the failover mechanism.
Is there any reason for non-static loggers? The non-static logger in
FailOverBag destroyes the serialization.

I could provide a patch which will change all loggers to static.

Regards,
Thomas

Re: Rework logger API (OWB-674) breaks failover/serialization

Posted by Mark Struberg <st...@yahoo.de>.

Thanks Thomas, we will look at it. 

We will be shipping a 1.1.6 version shortly.

LieGrue,
strub




----- Original Message -----
> From: Thomas Andraschko <zo...@gmail.com>
> To: dev@openwebbeans.apache.org
> Cc: 
> Sent: Friday, August 31, 2012 11:29 AM
> Subject: Re: Rework logger API (OWB-674) breaks failover/serialization
> 
>T his loggers could be static:
> 
> PluginLoader
> AbstractMetaDataDiscovery
> OsgiMetaDataScannerService
> FailOverBag
> FailOverBagWrapper
> 
> 
> There are 2 other classes where it can't be static without changes. Should
> we set them as transient?
> 
> WebContainerLifecycle
> AbstractLifeCycle
> 
> 
> 2012/8/31 Thomas Andraschko <zo...@gmail.com>
> 
>>  Hi,
>> 
>>  AFAICS the old WebBeansLogger was serializable and JUL isn't.
>>  This breaks again the failover because OWB has some or many non-static
>>  loggers. It's really annoying because since 1.1.3, every version 
> destroyed
>>  the failover mechanism.
>>  Is there any reason for non-static loggers? The non-static logger in
>>  FailOverBag destroyes the serialization.
>> 
>>  I could provide a patch which will change all loggers to static.
>> 
>>  Regards,
>>  Thomas
>> 
>

Re: Rework logger API (OWB-674) breaks failover/serialization

Posted by Romain Manni-Bucau <rm...@gmail.com>.

IMO all could be static, there is no good reason to keep them not static
Le 31 août 2012 14:30, "Thomas Andraschko" <zo...@gmail.com> a écrit :

> This loggers could be static:
>
> PluginLoader
> AbstractMetaDataDiscovery
> OsgiMetaDataScannerService
> FailOverBag
> FailOverBagWrapper
>
>
> There are 2 other classes where it can't be static without changes. Should
> we set them as transient?
>
> WebContainerLifecycle
> AbstractLifeCycle
>
>
> 2012/8/31 Thomas Andraschko <zo...@gmail.com>
>
> > Hi,
> >
> > AFAICS the old WebBeansLogger was serializable and JUL isn't.
> > This breaks again the failover because OWB has some or many non-static
> > loggers. It's really annoying because since 1.1.3, every version
> destroyed
> > the failover mechanism.
> > Is there any reason for non-static loggers? The non-static logger in
> > FailOverBag destroyes the serialization.
> >
> > I could provide a patch which will change all loggers to static.
> >
> > Regards,
> > Thomas
> >
>

Re: Rework logger API (OWB-674) breaks failover/serialization

Posted by Thomas Andraschko <zo...@gmail.com>.

This loggers could be static:

PluginLoader
AbstractMetaDataDiscovery
OsgiMetaDataScannerService
FailOverBag
FailOverBagWrapper


There are 2 other classes where it can't be static without changes. Should
we set them as transient?

WebContainerLifecycle
AbstractLifeCycle


2012/8/31 Thomas Andraschko <zo...@gmail.com>

> Hi,
>
> AFAICS the old WebBeansLogger was serializable and JUL isn't.
> This breaks again the failover because OWB has some or many non-static
> loggers. It's really annoying because since 1.1.3, every version destroyed
> the failover mechanism.
> Is there any reason for non-static loggers? The non-static logger in
> FailOverBag destroyes the serialization.
>
> I could provide a patch which will change all loggers to static.
>
> Regards,
> Thomas
>