You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/28 22:13:48 UTC
[GitHub] [incubator-superset] ktmud opened a new issue #11094: DatasourceControl dropdown z-index issue
ktmud opened a new issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094
When datasource name is long or browser window is small, DatasourceControl dropdown menu cut in half on narrow screens.
### Expected results
The dropdown menu should be able to overflow from the side bar.
Another option is to right-align the dropdown menu.
### Actual results
#### How to reproduce the bug
1. Go to Explore page
2. Select a datasource with very long name
3. Narrow your browser window
4. Click on the "..." dropdown.
### Environment
(please complete the following information):
- superset version: `superset version`
- python version: `python --version`
- node.js version: `node -v`
- npm version: `npm -v`
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [ x I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Should be related to #10971
cc @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11094: style: DatasourceControl dropdown z-index issue
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094#issuecomment-712945506
I think it's going to solve itself when I refactor react-bootstrap dropdowns to Antd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zuzana-vej commented on issue #11094: style: DatasourceControl dropdown z-index issue
Posted by GitBox <gi...@apache.org>.
zuzana-vej commented on issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094#issuecomment-714581952
Similar to https://github.com/apache/incubator-superset/issues/11377 (these are the only two cosmetic / overflow issues I am aware of).
cc @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11094: style: DatasourceControl dropdown z-index issue
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094#issuecomment-714619402
@ktmud @junlincc https://github.com/apache/incubator-superset/pull/11395 should fix the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #11094: style: DatasourceControl dropdown z-index issue
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094#issuecomment-716035413
Merged, and confirmed this is fixed in master:
<img width="588" alt="Screen Shot 2020-10-24 at 11 26 05 AM" src="https://user-images.githubusercontent.com/487433/97089313-b9954f00-15eb-11eb-94e0-01df65232a60.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on issue #11094: style: DatasourceControl dropdown z-index issue
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094#issuecomment-714619402
@ktmud @zuzana-vej @junlincc https://github.com/apache/incubator-superset/pull/11395 should fix the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on issue #11094: style: DatasourceControl dropdown z-index issue
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094#issuecomment-708899075
@kgabryje 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch closed issue #11094: style: DatasourceControl dropdown z-index issue
Posted by GitBox <gi...@apache.org>.
mistercrunch closed issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11094: DatasourceControl dropdown z-index issue
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11094:
URL: https://github.com/apache/incubator-superset/issues/11094#issuecomment-700311855
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.93. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org