You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "HattoriHenzo (via GitHub)" <gi...@apache.org> on 2023/03/19 17:14:40 UTC
[GitHub] [incubator-eventmesh] HattoriHenzo opened a new pull request, #3487: [ISSUE #863] Add test to [eventmesh-storage-standalone] module
HattoriHenzo opened a new pull request, #3487:
URL: https://github.com/apache/incubator-eventmesh/pull/3487
Fixes https://github.com/apache/incubator-eventmesh/issues/863
### Modifications
*Describe the modifications you've done.*
Add unit test. Another task will be to refactor some part of the module. Some methods are a bit difficult to test.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] HattoriHenzo commented on pull request #3487: [ISSUE #863] Add test to [eventmesh-storage-standalone] module
Posted by "HattoriHenzo (via GitHub)" <gi...@apache.org>.
HattoriHenzo commented on PR #3487:
URL: https://github.com/apache/incubator-eventmesh/pull/3487#issuecomment-1476179970
@xwm1992 I would like to continue with other tests but there a some refactoring that can be done in the module. The constructor of the class `StandaloneAdmin` seems to take in parameter a `Propertie` that is not used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on pull request #3487: [ISSUE #863] Add test to [eventmesh-storage-standalone] module
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #3487:
URL: https://github.com/apache/incubator-eventmesh/pull/3487#issuecomment-1475509018
@HattoriHenzo please help fix the ci check error in `HeartBeatProcessor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 merged pull request #3487: [ISSUE #863] Add test to [eventmesh-storage-standalone] module
Posted by "mytang0 (via GitHub)" <gi...@apache.org>.
mytang0 merged PR #3487:
URL: https://github.com/apache/incubator-eventmesh/pull/3487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3487: [ISSUE #863] Add test to [eventmesh-storage-standalone] module
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3487:
URL: https://github.com/apache/incubator-eventmesh/pull/3487#issuecomment-1475571876
## [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3487?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3487](https://codecov.io/gh/apache/incubator-eventmesh/pull/3487?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ba8cb4) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/41a21459da49b529b2dc70eca85b7b9a44a8d72a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (41a2145) will **increase** coverage by `0.37%`.
> The diff coverage is `25.00%`.
> :exclamation: Current head 9ba8cb4 differs from pull request most recent head 93a2c58. Consider uploading reports for the commit 93a2c58 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3487 +/- ##
============================================
+ Coverage 14.24% 14.61% +0.37%
- Complexity 1482 1526 +44
============================================
Files 651 651
Lines 31711 31702 -9
Branches 3034 3019 -15
============================================
+ Hits 4516 4633 +117
+ Misses 26798 26655 -143
- Partials 397 414 +17
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/3487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...re/protocol/http/processor/HeartBeatProcessor.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvSGVhcnRCZWF0UHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...torage/standalone/consumer/StandaloneConsumer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXN0b3JhZ2UvZXZlbnRtZXNoLXN0b3JhZ2Utc3RhbmRhbG9uZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3N0b3JhZ2Uvc3RhbmRhbG9uZS9jb25zdW1lci9TdGFuZGFsb25lQ29uc3VtZXIuamF2YQ==) | `37.50% <ø> (+37.50%)` | :arrow_up: |
| [...tmesh/client/grpc/producer/CloudEventProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/3487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2dycGMvcHJvZHVjZXIvQ2xvdWRFdmVudFByb2R1Y2VyLmphdmE=) | `56.06% <60.00%> (ø)` | |
... and [14 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-eventmesh/pull/3487/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org