You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/04/13 20:09:14 UTC

[GitHub] [netbeans] jtulach opened a new pull request #2881: Upgrading to SigTest 1.4 and using its release attribute

jtulach opened a new pull request #2881:
URL: https://github.com/apache/netbeans/pull/2881


   New version of SigTest [supports the release attribute](https://github.com/jtulach/netbeans-apitest/pull/3). That allows us to fix the JDK API to particular version. The PR sets it to `${javac.target}` for each module. To verify how this behaves try for example:
   ```bash
   platform/openide.util.lookup$ ant clean build check-sigtest -Djavac.target=11  -Dsigtest.check.type=strictcheck
   
   Missed Annotations
   ------------------
   
   org.openide.util.Lookup$Template.init:  anno 0 java.lang.Deprecated()
   org.openide.util.lookup.implspi.AbstractServiceProviderProcessor.register:      anno 0 java.lang.Deprecated()
   
   Added Annotations
   -----------------
   
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   java.lang.Object.finalize:              anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="9")
   org.openide.util.Lookup$Template.init:  anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="")
   org.openide.util.lookup.implspi.AbstractServiceProviderProcessor.register:      anno 0 java.lang.Deprecated(boolean forRemoval=false, java.lang.String since="")
   ```
   e.g. the report includes changes done in between JDK8 and JDK11 to `Object.finalize` and attributes of `Deprecated`. CCing @neilcsmith-net + @geertjanw 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net commented on pull request #2881: Upgrading to SigTest 1.4 and using its release attribute

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2881:
URL: https://github.com/apache/netbeans/pull/2881#issuecomment-819444722


   Looks a good move!  I was just going to liaise with @geertjanw about the API snapshot, which for 12.3 we did initially before freeze so we could get useful review.  Is this intended for 12.4?  Should I wait until this merges?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jtulach commented on pull request #2881: Upgrading to SigTest 1.4 and using its release attribute

Posted by GitBox <gi...@apache.org>.
jtulach commented on pull request #2881:
URL: https://github.com/apache/netbeans/pull/2881#issuecomment-819212141


   First [error is reported](https://travis-ci.com/github/apache/netbeans/jobs/498248762) and it can be interpreted as the power of `--release` option!
   ```
   Class org.netbeans.lib.profiler.utils.ImmutableList
     "E1.2 - API type removed" : method public java.util.Spliterator java.lang.Iterable.spliterator()
     "E1.2 - API type removed" : method public void java.lang.Iterable.forEach(java.util.function.Consumer)
   ```
   The `lib.profiler` project sets `javac.target=1.7` and SigTest version 1.4 properly sees only JDK7 APIs now! 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #2881: Upgrading to SigTest 1.4 and using its release attribute

Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #2881:
URL: https://github.com/apache/netbeans/pull/2881#issuecomment-819444722


   Looks a good move!  I was just going to liaise with @geertjanw about the API snapshot, which for 12.3 we did initially before freeze so we could get useful review.  Is this intended for 12.4?  Should we wait until this merges?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach merged pull request #2881: Upgrading to SigTest 1.4 and using its release attribute

Posted by GitBox <gi...@apache.org>.
JaroslavTulach merged pull request #2881:
URL: https://github.com/apache/netbeans/pull/2881


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] JaroslavTulach commented on pull request #2881: Upgrading to SigTest 1.4 and using its release attribute

Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on pull request #2881:
URL: https://github.com/apache/netbeans/pull/2881#issuecomment-821305401


   Yes, if it seems to work (and it does). Let's use it for 12.4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists