[jira] [Commented] (YUNIKORN-55) Add pod labels and annotations to allocation ask attributes

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17097188#comment-17097188 ] 

Wilfred Spiegelenburg commented on YUNIKORN-55:
-----------------------------------------------

As I commented in the PR just blindly adding all meta data from the pod on asks is I think not the right thing to do. Some make sense only on the app and like namespace are already there.
Can we get a more detailed description of what we want, expect or need from the labels and annotations?

I think filtering for the ask would be the right way forward: 
* specific labels from the pod on each ask, remove app level ones
* all labels with namespace {{yunikorn.apapche.org}}
* no annotations for now due to the structure and content

> Add pod labels and annotations to allocation ask attributes
> -----------------------------------------------------------
>
>                 Key: YUNIKORN-55
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-55
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - scheduler, shim - kubernetes, webapp
>            Reporter: Weiwei Yang
>            Assignee: Adam Antal
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 38m
>  Remaining Estimate: 1h 28m
>
> In YUNIKORN-54, we simplify the way to generate application IDs. The side effect is when we look at info from web UI, we lose some info about the pod info such as pod name, namespace, etc.
> A proper way to handle this is to get this info from pod and add labels, annotations info to allocation ask as attributes, and then send to scheduler-core. Also on web rest API, we need to display these attributes too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org