[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance

["Roger Whitcomb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382591#comment-16382591 ] 

Roger Whitcomb commented on PIVOT-1032:
---------------------------------------

The "1032.diffs.txt" shows the "build.xml" changes (along with adding "checkstyle-8.8-all.jar" to the ANT_HOME/lib directory and the "sun_checks.xml" to the root directory) in order to get the task running.

Initial results show:   

Got 43287 errors and 0 warnings.

So, a LOT of work to triage and fix these "errors".

> Implement "checkstyle" for builds and make changes to bring code into better compliance
> ---------------------------------------------------------------------------------------
>
>                 Key: PIVOT-1032
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1032
>             Project: Pivot
>          Issue Type: Improvement
>            Reporter: Roger Whitcomb
>            Assignee: Roger Whitcomb
>            Priority: Minor
>         Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task already implemented, to do some sort of "checkstyle" processing to evaluate all the code to see where there might be changes to make the code more robust and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we *should*), but there might be things that would make the code better and easier to read and maintain, and wouldn't take much effort.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)