You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/01/03 23:51:09 UTC
Re: Review Request 69597: Remove outstanding operations when removing
agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69597/#review211661
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 11004 (patched)
<https://reviews.apache.org/r/69597/#comment297117>
s/scheudler/scheduler/
src/master/master.cpp
Lines 11005 (patched)
<https://reviews.apache.org/r/69597/#comment297118>
s/anyways/anyway/
- Greg Mann
On Dec. 27, 2018, 4:51 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69597/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2018, 4:51 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Usually, offer operations are removed when the framework acknowledges
> a terminal operation status update.
>
> However, currently only operations on registered agents can be
> acknowledged.
>
> This commit explicitly deletes all outstanding operations from an agent
> when it is removed.
>
>
> Diffs
> -----
>
> src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316
>
>
> Diff: https://reviews.apache.org/r/69597/diff/4/
>
>
> Testing
> -------
>
> Internal CI results:
> ```
> Test Result
> 0 failures
> 38,673 tests
>
> Configuration Name Duration All Failed Skipped
> FLAG=Plain,label=mesos-ec2-ubuntu-16.04 18 min 3202 0 0
> FLAG=SSL,label=mac 9 min 27 sec 2698 0 0
> FLAG=CMake,label=mesos-ec2-centos-7 21 min 3146 0 0
> FLAG=CMake,label=mesos-ec2-ubuntu-16.04 18 min 3155 0 0
> FLAG=SSL,label=mesos-ec2-debian-8 21 min 3261 0 0
> FLAG=SSL,label=mesos-ec2-centos-7 20 min 3256 0 0
> FLAG=Plain,label=mesos-ec2-centos-7 20 min 3193 0 0
> FLAG=SSL,label=mesos-ec2-ubuntu-16.04 18 min 3265 0 0
> FLAG=SSL,label=mesos-ec2-ubuntu-14.04 19 min 3258 0 0
> FLAG=Clang,label=mesos-ec2-ubuntu-16.04 18 min 3202 0 0
> FLAG=SSL,label=mesos-ec2-debian-9 18 min 3263 0 0
> FLAG=SSL,label=mesos-ec2-centos-6 15 min 3168 0 0
> FLAG=BUILD_ISOLATORS,label=mesos-ec2-ubuntu-16.04 5.6 sec 606 0 0
> ```
>
>
> Thanks,
>
> Benno Evers
>
>