[jira] [Commented] (MADLIB-1012) Path - error on symbols defined with underscore "_"

["Frank McQuillan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MADLIB-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421910#comment-15421910 ] 

Frank McQuillan commented on MADLIB-1012:
-----------------------------------------

looks good, I just tried it

> Path - error on symbols defined with underscore "_"
> ---------------------------------------------------
>
>                 Key: MADLIB-1012
>                 URL: https://issues.apache.org/jira/browse/MADLIB-1012
>             Project: Apache MADlib
>          Issue Type: Bug
>          Components: Module: Utilities
>            Reporter: Frank McQuillan
>             Fix For: v1.9.1
>
>
> So when I was looking at
> https://issues.apache.org/jira/browse/MADLIB-995
> I observed that 
> {code}
> SELECT madlib.path(                                                                   
>      'eventlog',                    -- Name of the table                                           
>      'path_output',                 -- Table name to store the path results                         
>      'session_id',                  -- Partition by session                 
>      'event_timestamp ASC',         -- Order partitions in input table by time       
>      $$ no_buy:=page<>'CHECKOUT',
>         buy:=page='CHECKOUT'
>      $$,  -- Definition of symbols used in the pattern definition 
>      '(no_buy)+(buy)',         -- At least one page followed by and ending with a CHECKOUT.
>      'array_agg(page ORDER BY session_id ASC, event_timestamp ASC) as page_path',  
>      FALSE,                        -- Persist matches
>      TRUE                          -- turn on overlapping patterns
>      );
> {code}
> is failing for "no_buy"  with this message: 
> psql:test-overlapping.sql:31: ERROR:  KeyError: '"no_buy"'
> CONTEXT:  Traceback (most recent call last):
>   PL/Python function "path", line 23, in <module>
>     return path.path(**globals())
>   PL/Python function "path", line 71, in path
>   PL/Python function "path", line 300, in _parse_symbol_str
> PL/Python function "path"
> If I change to "nobuy" it works OK.
> Please check it since https://www.postgresql.org/docs/8.2/static/plpgsql-statements.html seems to allow "_" for identifiers.
> The wider question is are we supporting standard postgres identifiers for symbols?  I thought yes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)