You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2018/10/25 20:06:01 UTC

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22838#discussion_r228311880
  
    --- Diff: pom.xml ---
    @@ -2654,6 +2654,16 @@
     
         <profile>
           <id>kubernetes</id>
    +      <modules>
    +        <module>resource-managers/kubernetes/core</module>
    +      </modules>
    +    </profile>
    +
    +    <profile>
    +      <id>kubernetes-tests</id>
    +      <activation>
    +      <activeByDefault>false</activeByDefault>
    --- End diff --
    
    Ah right I had https://github.com/apache/spark/pull/22829 open; I can close it in favor of this. 
    Nit: the indent is off here. But, you don't need this section at all. Profiles are not active by default.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org