You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/02 02:54:51 UTC

[GitHub] [shardingsphere] RaigorJiang opened a new issue #15731: [OpenForce 2022] Add SQL parser test case for `DropScalingStatement`

RaigorJiang opened a new issue #15731:
URL: https://github.com/apache/shardingsphere/issues/15731


   Hi community,
   
   This issue is for [OpenForce 2022](https://github.com/apache/shardingsphere/discussions/12683#discussioncomment-2139441)
   
   
   ### Background
   
   `DROP SCALING jobId` is a syntax in [DistSQL RAL](https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-proxy/distsql/syntax/ral/), when `ShardingSphereSQLParserEngine` receives this SQL text, it parses it as `DropScalingStatement`. Now we need to add a test case for this parsing process to assert that its parsing is correct.
   
   
   ### Aim
   
   Add SQL parser test case for `DropScalingStatement`.
   
   - Affected files:
   
     - `SQLParserTestCases` (modify)
   
     - `shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ral/update.xml` (modify)
   
     - `shardingsphere-test/shardingsphere-parser-test/src/main/resources/sql/supported/ral/update.xml` (modify)
   
     - `shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/statement/distsql/ral/scaling/DropScalingStatementTestCase.java` (create )
   
     - `shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/ral/impl/scaling/update/DropScalingStatementAssert.java` (create )
   
     - `UpdatableScalingRALStatementAssert` (modify)
   
   
   - After all, execute `DistSQLParserParameterizedTest#assertDistSQL()` for validation
   
   ### Basic Qualifications
   
   - Java
   - Maven
   
   
   ### Example FYI
   
   - `ApplyScalingStatement`
   - `ApplyScalingStatementTestCase`
   - `ApplyScalingStatementAssert`
   - search for "apply-scaling"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] pparthenhs commented on issue #15731: [OpenForce 2022] Add SQL parser test case for `DropScalingStatement`

Posted by GitBox <gi...@apache.org>.
pparthenhs commented on issue #15731:
URL: https://github.com/apache/shardingsphere/issues/15731#issuecomment-1056796767


   Dear @RaigorJiang , 
   
   I start working on this issue. 
   
   I will let you know when I am finished.
   
   Best regards, 
   Panagiotis Parthenis


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed issue #15731: [OpenForce 2022] Add SQL parser test case for `DropScalingStatement`

Posted by GitBox <gi...@apache.org>.
RaigorJiang closed issue #15731:
URL: https://github.com/apache/shardingsphere/issues/15731


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org