You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/07/25 14:42:31 UTC
Review Request 68039: Padded using the type name in `MpscLinkedQueue`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68039/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Dario Rexin.
Repository: mesos
Description
-------
The Windows build doesn't accept the name of the `tail` member
variable when defining the padding, so use the type name instead.
Diffs
-----
3rdparty/libprocess/src/mpsc_linked_queue.hpp 0036eb8d6c0a8dc6f78dc552c8f5500305985172
Diff: https://reviews.apache.org/r/68039/diff/1/
Testing
-------
None (waiting for reviewbot)
Thanks,
James Peach
Re: Review Request 68039: Padded using the type name in
`MpscLinkedQueue`.
Posted by Dario Rexin <da...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68039/#review206461
-----------------------------------------------------------
Ship it!
Ship It!
- Dario Rexin
On July 25, 2018, 2:42 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68039/
> -----------------------------------------------------------
>
> (Updated July 25, 2018, 2:42 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Dario Rexin.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Windows build doesn't accept the name of the `tail` member
> variable when defining the padding, so use the type name instead.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/mpsc_linked_queue.hpp 0036eb8d6c0a8dc6f78dc552c8f5500305985172
>
>
> Diff: https://reviews.apache.org/r/68039/diff/1/
>
>
> Testing
> -------
>
> None (waiting for reviewbot)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 68039: Padded using the type name in
`MpscLinkedQueue`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68039/#review206452
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68039']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1980/mesos-review-68039
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1980/mesos-review-68039/logs/mesos-tests-stdout.log):
```
[ RUN ] SlaveTest.ResourceVersions
[ OK ] SlaveTest.ResourceVersions (209 ms)
[ RUN ] SlaveTest.ReconfigurationPolicy
[ OK ] SlaveTest.ReconfigurationPolicy (293 ms)
[ RUN ] SlaveTest.ResourceProviderReconciliation
[ OK ] SlaveTest.ResourceProviderReconciliation (354 ms)
[ RUN ] SlaveTest.RunTaskResourceVersions
[ OK ] SlaveTest.RunTaskResourceVersions (310 ms)
[----------] 81 tests from SlaveTest (53362 ms total)
[----------] 3 tests from SlaveStateTest
[ RUN ] SlaveStateTest.CheckpointString
[ OK ] SlaveStateTest.CheckpointString (4 ms)
[ RUN ] SlaveStateTest.CheckpointProtobufMessage
[ OK ] SlaveStateTest.CheckpointProtobufMessage (9 ms)
[ RUN ] SlaveStateTest.CheckpointRepeatedProtobufMessages
[ OK ] SlaveStateTest.CheckpointRepeatedProtobufMessages (8 ms)
[----------] 3 tests from SlaveStateTest (23 ms total)
[----------] 30 tests from SlaveRecoveryTest/0, where TypeParam = class mesos::internal::slave::MesosContainerizer
[ RUN ] SlaveRecoveryTest/0.RecoverSlaveState
[ OK ] SlaveRecoveryTest/0.RecoverSlaveState (677 ms)
[ RUN ] SlaveRecoveryTest/0.RecoverTaskStatusUpdateManager
[ OK ] SlaveRecoveryTest/0.RecoverTaskStatusUpdateManager (2788 ms)
[ RUN ] SlaveRecoveryTest/0.ReconnectExecutor
[ OK ] SlaveRecoveryTest/0.ReconnectExecutor (3077 ms)
[ RUN ] SlaveRecoveryTest/0.ReconnectExecutorRetry
[ OK ] SlaveRecoveryTest/0.ReconnectExecutorRetry (877 ms)
[ RUN ] SlaveRecoveryTest/0.PingTimeoutDuringRecovery
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1980/mesos-review-68039/logs/mesos-tests-stderr.log):
```
@ 00007FF6A0102577 ??
@ 00007FF69FFC01E8 std::_Invoker_functor::_Call<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,process::ProcessBase *>
@ 00007FF6A00540F8 std::invoke<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,process::ProcessBase *>
@ 00007FF6A0068DEB lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> >::invoke_expand<<lambda_9f5bb6c728b761604e288ae85a7b250c>,std::tuple<process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> >,st
@ 00007FF69FF96A3A )<process::ProcessBase *
@ 00007FF69FFC689C std::_Invoker_functor::_Call<lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> >,process::ProcessBase *>
@ 00007FF6A005A66C std::invoke<lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> >,process::ProcessBase *>
@ 00007FF69FFA0131 )<lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> >,process::ProcessBase *
@ 00007FF6A010CB36 process::ProcessBase *)>::CallableFn<lambda::internal::Partial<<lambda_9f5bb6c728b761604e288ae85a7b250c>,process::Future<Option<mesos::MasterInfo> >,std::_Ph<1> > >::operator(
@ 00007FF6A1A2828D process::ProcessBase *)>::operator(
@ 00007FF6A18D2DE9 process::ProcessBase::consume
@ 00007FF6A1A82DEA process::DispatchEvent::consume
@ 00007FF69DB2F647 process::ProcessBase::serve
@ 00007FF6A18E0990 process::ProcessManager::resume
@ 00007FF6A1A13D51 ??
@ 00007FF6A19333E0 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF6A1995260 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF6A1948FDC std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0>
@ 00007FF6A1A6996A std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run
@ 00007FF6A1A54F58 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go
@ 00007FF6A1A3AA8D std::_Pad::_Call_func
@ 00007FFA12933428 _register_onexit_function
@ 00007FFA12933071 _register_onexit_function
@ 00007FFA2A1E1FE4 BaseThreadInitThunk
@ 00007FFA2C8EF061 RtlUserThreadStart
xecutor(1)@192.10.1.6:62478
I0725 15:58:08.750223 37200 slave.cpp:4984] Received re-registration message from executor '58efce3d-b747-4d8d-a4ff-c8635358561d' of framework 769b8977-3452-4f96-b427-f6f79f29476e-0000
I0725 15:58:08.754226 36740 slave.cpp:5901] No pings from master received within 75secs
F0725 15:58:08.756228 36740 slave.cpp:1249] Check failed: state == DISCONNECTED || state == RUNNING || state == TERMINATING RECOVERING
```
- Mesos Reviewbot Windows
On July 25, 2018, 2:42 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68039/
> -----------------------------------------------------------
>
> (Updated July 25, 2018, 2:42 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, and Dario Rexin.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The Windows build doesn't accept the name of the `tail` member
> variable when defining the padding, so use the type name instead.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/mpsc_linked_queue.hpp 0036eb8d6c0a8dc6f78dc552c8f5500305985172
>
>
> Diff: https://reviews.apache.org/r/68039/diff/1/
>
>
> Testing
> -------
>
> None (waiting for reviewbot)
>
>
> Thanks,
>
> James Peach
>
>