You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/02/28 12:47:39 UTC
[GitHub] spark pull request #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of ...
GitHub user jiangxb1987 opened a pull request:
https://github.com/apache/spark/pull/20693
[SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of OptimizeMetadataOnlyQuery
## What changes were proposed in this pull request?
Inside `OptimizeMetadataOnlyQuery.getPartitionAttrs`, avoid using `zip` to generate attribute map.
Also include other minor update of comments and format.
## How was this patch tested?
Existing test cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiangxb1987/spark SPARK-23523
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20693.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20693
----
commit a3cf3ca98298ec43a7163e53e851a32e483f4c42
Author: Xingbo Jiang <xi...@...>
Date: 2018-02-28T12:38:15Z
refactor
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20693
**[Test build #87783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87783/testReport)** for PR 20693 at commit [`a3cf3ca`](https://github.com/apache/spark/commit/a3cf3ca98298ec43a7163e53e851a32e483f4c42).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87775/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1147/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20693
**[Test build #87775 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87775/testReport)** for PR 20693 at commit [`a3cf3ca`](https://github.com/apache/spark/commit/a3cf3ca98298ec43a7163e53e851a32e483f4c42).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class LocalRelation(output: Seq[Attribute],`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20693
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20693
**[Test build #87783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87783/testReport)** for PR 20693 at commit [`a3cf3ca`](https://github.com/apache/spark/commit/a3cf3ca98298ec43a7163e53e851a32e483f4c42).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class LocalRelation(output: Seq[Attribute],`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of ...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20693#discussion_r171275557
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LocalRelation.scala ---
@@ -43,11 +43,10 @@ object LocalRelation {
}
}
-case class LocalRelation(
- output: Seq[Attribute],
- data: Seq[InternalRow] = Nil,
- // Indicates whether this relation has data from a streaming source.
- override val isStreaming: Boolean = false)
+case class LocalRelation(output: Seq[Attribute],
--- End diff --
although we should not include this style change in the original commit, since it's already there, let's not bother about reverting it back.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/20693
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20693
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20693
**[Test build #87787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87787/testReport)** for PR 20693 at commit [`0a3d84a`](https://github.com/apache/spark/commit/0a3d84af6cec90df72ebaf3d16f231cdb5c627aa).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1152/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20693
**[Test build #87775 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87775/testReport)** for PR 20693 at commit [`a3cf3ca`](https://github.com/apache/spark/commit/a3cf3ca98298ec43a7163e53e851a32e483f4c42).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/20693
cc @gatorsmile @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20693
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1156/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87783/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20693
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87787/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20693: [SPARK-23523] [SQL] [FOLLOWUP] Minor refactor of Optimiz...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20693
**[Test build #87787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87787/testReport)** for PR 20693 at commit [`0a3d84a`](https://github.com/apache/spark/commit/0a3d84af6cec90df72ebaf3d16f231cdb5c627aa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class LocalRelation(`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org