[GitHub] [cordova-android] breautek commented on pull request #1220: fix(requirements check): use regex to get java version from javac output

[GitBox <gi...@apache.org>]

breautek commented on pull request #1220:
URL: https://github.com/apache/cordova-android/pull/1220#issuecomment-826815377


   > I also tried removing _JAVA_OPTIONS from the version check by adding env: {}, extendEnv: false to the options of the javac command like suggested here:
   
   Yah I don't think we can remove the environment variables, as that may contain details like `JAVA_HOME` used to point to the direction where Cordova should look for a path... otherwise it will find the first java variable in your path and call it a day which may not be what we want. ;)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org