You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/28 15:58:57 UTC
[GitHub] [incubator-doris] chenlinzhong opened a new pull request, #9305: [style] clang-format all c++ code
chenlinzhong opened a new pull request, #9305:
URL: https://github.com/apache/incubator-doris/pull/9305
# Proposed changes
Issue Number:
## Problem Summary:
- now all pr failed in "BE Code Formatter / Clang Formatter" check
- sh build-support/clang-format.sh to clang-format all c++ code
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9305: [style] clang-format all c++ code
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9305:
URL: https://github.com/apache/incubator-doris/pull/9305#issuecomment-1112838276
hi @chenlinzhong , please also add this:
https://github.com/apache/incubator-doris/blob/c132abd2bdbbd6e86b61eedc84473a891fb69880/.asf.yaml#L37-L44
Enable this `# - Clang Formatter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9305: [style] clang-format all c++ code
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9305:
URL: https://github.com/apache/incubator-doris/pull/9305#issuecomment-1112809138
@chenlinzhong please rebase because #9280 has been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9305: [style] clang-format all c++ code
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9305:
URL: https://github.com/apache/incubator-doris/pull/9305#issuecomment-1112810957
And you'd better send an email to dev@doris to notice others.
Because this PR may be conflict with all other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #9305: [style] clang-format all c++ code
Posted by GitBox <gi...@apache.org>.
morningman merged PR #9305:
URL: https://github.com/apache/incubator-doris/pull/9305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chenlinzhong commented on pull request #9305: [style] clang-format all c++ code
Posted by GitBox <gi...@apache.org>.
chenlinzhong commented on PR #9305:
URL: https://github.com/apache/incubator-doris/pull/9305#issuecomment-1112841073
>
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chenlinzhong commented on pull request #9305: [style] clang-format all c++ code
Posted by GitBox <gi...@apache.org>.
chenlinzhong commented on PR #9305:
URL: https://github.com/apache/incubator-doris/pull/9305#issuecomment-1112828778
> @chenlinzhong please rebase because #9280 has been merged
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9305: [style] clang-format all c++ code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9305:
URL: https://github.com/apache/incubator-doris/pull/9305#issuecomment-1113008647
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9305: [style] clang-format all c++ code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9305:
URL: https://github.com/apache/incubator-doris/pull/9305#issuecomment-1113008674
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org