[GitHub] [helix] jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.
URL: https://github.com/apache/helix/pull/357#discussion_r306517713
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
 ##########
 @@ -850,6 +858,56 @@ public static JobConfig getJobConfig(HelixManager manager, String job) {
     return workflowConfigMap;
   }
 
+  /**
+   * Batch get the configurations of all workflows in this cluster
+   * within the specified timeout in milliseconds.
+   *
+   * @param timeout a long integer presents the timeout, in milliseconds
+   * @return a map of <String, WorkflowConfig>
+   * @throws InterruptedException if the future thread was interrupted
+   * @throws ExecutionException if the future task completed exceptionally
+   * @throws TimeoutException if waiting for result timed out
+   */
+  public Map<String, WorkflowConfig> getWorkflows(long timeout)
+    throws CancellationException, InterruptedException, ExecutionException, TimeoutException {
+    if (timeout <= 0L) {
+      throw new IllegalArgumentException("timeout must be positive.");
+    }
+    
+    ExecutorService executorService = Executors.newSingleThreadExecutor();
 
 Review comment:
   Create a new executor on every call is not optimal. Can we have a static object?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services