You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dataroaring (via GitHub)" <gi...@apache.org> on 2026/04/10 09:42:03 UTC
[PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
dataroaring opened a new pull request, #62343:
URL: https://github.com/apache/doris/pull/62343
## Summary
- Remove stale `#include "common/compile_check_begin.h"` and `#include "common/compile_check_end.h"` from `schema_role_mappings_scanner.cpp`
- These headers were deleted globally in #62300, but `schema_role_mappings_scanner.cpp` (added by #62077) still referenced them, causing a compile failure on master
## Root Cause
PR #62077 and PR #62300 were prepared independently. #62077 added a new file with the compile_check includes, while #62300 deleted those headers. After both merged, master fails to compile with:
```
fatal error: 'common/compile_check_begin.h' file not found
```
## Test plan
- [ ] Verify master compiles successfully after this change
---
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #62343:
URL: https://github.com/apache/doris/pull/62343#issuecomment-4222610849
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62343:
URL: https://github.com/apache/doris/pull/62343#issuecomment-4222885859
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62343:
URL: https://github.com/apache/doris/pull/62343#issuecomment-4223657695
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62343_38d962d03db36ed5d337763e4882fc2a286da759_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62343_38d962d03db36ed5d337763e4882fc2a286da759_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.65% (27398/37198) |
| Line Coverage | 57.31% (295843/516243) |
| Region Coverage | 54.53% (246453/451925) |
| Branch Coverage | 56.19% (106823/190105) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #62343:
URL: https://github.com/apache/doris/pull/62343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62343:
URL: https://github.com/apache/doris/pull/62343#issuecomment-4230976036
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62343_38d962d03db36ed5d337763e4882fc2a286da759_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62343_38d962d03db36ed5d337763e4882fc2a286da759_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.66% (27401/37198) |
| Line Coverage | 57.31% (295884/516243) |
| Region Coverage | 54.56% (246586/451925) |
| Branch Coverage | 56.21% (106861/190105) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62343:
URL: https://github.com/apache/doris/pull/62343#issuecomment-4222886032
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62343:
URL: https://github.com/apache/doris/pull/62343#issuecomment-4222610431
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](compile) Remove stale compile_check includes from schema_role_mappings_scanner [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62343:
URL: https://github.com/apache/doris/pull/62343#issuecomment-4249750807
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org