You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2023/06/07 13:27:36 UTC
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2162: IGNITE-19493 Sql. Change query execution flow
AMashenkov commented on code in PR #2162:
URL: https://github.com/apache/ignite-3/pull/2162#discussion_r1221602608
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -425,6 +421,18 @@ private CompletableFuture<AsyncSqlCursor<List<Object>>> querySingle0(
.thenCompose(sqlNode -> {
boolean rwOp = dataModificationOp(sqlNode);
+ boolean implicitTxRequired = outerTx == null;
+
+ tx.set(implicitTxRequired ? txManager.begin(!rwOp) : outerTx);
+
+ SchemaPlus schema = sqlSchemaManager.schema(schemaName);
Review Comment:
```suggestion
SchemaPlus schema = sqlSchemaManager.activeSchema(schemaName, tx.startTimestamp().longValue());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org