You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Andrei Sereda (JIRA)" <ji...@apache.org> on 2018/06/06 01:53:00 UTC

[jira] [Comment Edited] (CALCITE-2345) add tests using Fongo to Mongo Adapter

    [ https://issues.apache.org/jira/browse/CALCITE-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502735#comment-16502735 ] 

Andrei Sereda edited comment on CALCITE-2345 at 6/6/18 1:52 AM:
----------------------------------------------------------------

Pls take a look at [723|https://github.com/apache/calcite/pull/723]. I have tried to create a base class {{MongoIntegrationBase}}. 

Bad news is that fongo is pretty slow with large data-sets. And [is limiting|https://github.com/fakemongo/fongo/blob/master/src/main/java/com/mongodb/FongoDBCollection.java#L163] collection to 100k elements:
{quote}Whoa, hold up there.  Fongo's designed for lightweight testing.  100,000 items per collection max{quote}
Doesn't look like in practice it was meant for more than several dozen elements. Currently many tests run for 30 sec each.

You will notice that I'm doing [ugly string/replace|https://github.com/apache/calcite/pull/723/files#diff-2784ba4a7d4b5ad74d2af2b03bc31a89R121] of {{SchemaFactory}} class in order to inject populated database instance. Couldn't find a more elegant way when model is loaded from file.



was (Author: asereda):
Pls take a look at [723|https://github.com/apache/calcite/pull/723]. I have tried to create a base class {{MongoIntegrationBase}}. 

Bad news is that fongo is pretty slow with large data-sets. And [is limiting|https://github.com/fakemongo/fongo/blob/master/src/main/java/com/mongodb/FongoDBCollection.java#L163] collection to 100k elements:
{quote}Whoa, hold up there.  Fongo's designed for lightweight testing.  100,000 items per collection max{quote}
Doesn't look like in practice it was meant for more than several dozen elements. Currently many tests run for 30 sec each.





> add tests using Fongo to Mongo Adapter
> --------------------------------------
>
>                 Key: CALCITE-2345
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2345
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Andrei Sereda
>            Assignee: Michael Mior
>            Priority: Major
>
> Better test coverage for unit tests using [Fongo|https://github.com/fakemongo/fongo] which is in-memory implementation of Mongo API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)