You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/24 11:00:16 UTC

[GitHub] [spark] cloud-fan opened a new pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

cloud-fan opened a new pull request #33058:
URL: https://github.com/apache/spark/pull/33058


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error message, please read the guideline first:
        https://spark.apache.org/error-message-guidelines.html
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   Currently, AQE uses a very tricky to trigger and wait for the subqueries:
   1. submitting stage calls `QueryStageExec.materialize`
   2. `QueryStageExec.materialize` calls `executeQuery`
   3. `executeQuery` does some preparation works, which goes to `QueryStageExec.doPrepare`
   4. `QueryStageExec.doPrepare` calls `prepare` of shuffle/broadcast, which triggers all the subqueries in this stage
   5. `executeQuery` then calls `waitForSubqueries`, which does nothing because `QueryStageExec` itself has no subqueries
   6. then we start to execute shuffle/broadcast, without waiting for subqueries
   7. for `ShuffleExchangeExec`, it calls `child.execute`, which calls `executeQuery` and wait for subqueries in the query tree of `child`
   8. The only missing case is: `ShuffleExchangeExec` itself may contain subqueries and AQE doesn't wait for it.
   
   A simple fix would be overwriting `waitForSubqueries` in `QueryStageExec`, and forward the request to shuffle/broadcast, but this PR proposes a different and probably cleaner way: we follow `execute`/`doExecute` in `SparkPlan`, and add similar APIs in the AQE version of "execute", which gets a future from shuffle/broadcast.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   bug fix
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   a query fails without the fix and can run now
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   new test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872132141






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-875933385


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45276/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872169951


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45017/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867543258


   cc @maryannxue @JkSelf @viirya @yaooqinn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872211235


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140503/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-876573983






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] JkSelf commented on a change in pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
JkSelf commented on a change in pull request #33058:
URL: https://github.com/apache/spark/pull/33058#discussion_r658488482



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -58,7 +58,11 @@ trait BroadcastExchangeLike extends Exchange {
    * For registering callbacks on `relationFuture`.
    * Note that calling this method may not start the execution of broadcast job.
    */
-  def completionFuture: scala.concurrent.Future[broadcast.Broadcast[Any]]
+  final def submitBroadcastJob: scala.concurrent.Future[broadcast.Broadcast[Any]] = executeQuery {

Review comment:
       Can we add some comments for this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan closed pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #33058:
URL: https://github.com/apache/spark/pull/33058


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-875867374


   **[Test build #140764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140764/testReport)** for PR 33058 at commit [`6a7e388`](https://github.com/apache/spark/commit/6a7e388cc221a1c0b4f8709c53c7cadcbb3c3450).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872049267


   **[Test build #140503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140503/testReport)** for PR 33058 at commit [`c964743`](https://github.com/apache/spark/commit/c964743abd06b7a5646a501cddf522218bcf2b7f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867637721


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44795/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-876004517


   **[Test build #140764 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140764/testReport)** for PR 33058 at commit [`6a7e388`](https://github.com/apache/spark/commit/6a7e388cc221a1c0b4f8709c53c7cadcbb3c3450).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872186100


   **[Test build #140503 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140503/testReport)** for PR 33058 at commit [`c964743`](https://github.com/apache/spark/commit/c964743abd06b7a5646a501cddf522218bcf2b7f).
    * This patch passes all tests.
    * This patch **does not merge cleanly**.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-875910335


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45276/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-875933411


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45276/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867566567


   **[Test build #140263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140263/testReport)** for PR 33058 at commit [`1f7e6c1`](https://github.com/apache/spark/commit/1f7e6c13fd2491cf829b9c5827add31b09fec6ed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872211235


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140503/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867825324


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140265/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867644445


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44795/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867825324


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140265/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872132141


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45015/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
cloud-fan removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-876574068


   thanks for the review, merging to master/3.2!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33058:
URL: https://github.com/apache/spark/pull/33058#discussion_r657846088



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -58,7 +58,11 @@ trait BroadcastExchangeLike extends Exchange {
    * For registering callbacks on `relationFuture`.
    * Note that calling this method may not start the execution of broadcast job.
    */
-  def completionFuture: scala.concurrent.Future[broadcast.Broadcast[Any]]
+  final def completionFuture: scala.concurrent.Future[broadcast.Broadcast[Any]] = executeQuery {

Review comment:
       This is kind of the AQE version of "execute", as AQE won't call `execute` of shuffle/broadcast.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872132107


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45015/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872049267


   **[Test build #140503 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140503/testReport)** for PR 33058 at commit [`c964743`](https://github.com/apache/spark/commit/c964743abd06b7a5646a501cddf522218bcf2b7f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867566567


   **[Test build #140263 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140263/testReport)** for PR 33058 at commit [`1f7e6c1`](https://github.com/apache/spark/commit/1f7e6c13fd2491cf829b9c5827add31b09fec6ed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867600982


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44792/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33058:
URL: https://github.com/apache/spark/pull/33058#discussion_r657908370



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -58,7 +58,11 @@ trait BroadcastExchangeLike extends Exchange {
    * For registering callbacks on `relationFuture`.
    * Note that calling this method may not start the execution of broadcast job.
    */
-  def completionFuture: scala.concurrent.Future[broadcast.Broadcast[Any]]
+  final def submitBroadcastJob: scala.concurrent.Future[broadcast.Broadcast[Any]] = executeQuery {

Review comment:
       This is kind of the AQE version of "execute", as AQE won't call `execute` of shuffle/broadcast.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-876013444


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140764/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-875867374


   **[Test build #140764 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140764/testReport)** for PR 33058 at commit [`6a7e388`](https://github.com/apache/spark/commit/6a7e388cc221a1c0b4f8709c53c7cadcbb3c3450).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867801852


   **[Test build #140265 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140265/testReport)** for PR 33058 at commit [`c964743`](https://github.com/apache/spark/commit/c964743abd06b7a5646a501cddf522218bcf2b7f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-875933411


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45276/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-876013444


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140764/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872171357


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45017/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-876553648


   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867595070


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44792/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867605302


   **[Test build #140265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140265/testReport)** for PR 33058 at commit [`c964743`](https://github.com/apache/spark/commit/c964743abd06b7a5646a501cddf522218bcf2b7f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-872162929


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45017/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
cloud-fan removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-876574035


   thanks for the review, merging to master/3.2!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867788040


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140263/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867600338


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44792/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867605302


   **[Test build #140265 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140265/testReport)** for PR 33058 at commit [`c964743`](https://github.com/apache/spark/commit/c964743abd06b7a5646a501cddf522218bcf2b7f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867767109


   **[Test build #140263 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140263/testReport)** for PR 33058 at commit [`1f7e6c1`](https://github.com/apache/spark/commit/1f7e6c13fd2491cf829b9c5827add31b09fec6ed).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on a change in pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #33058:
URL: https://github.com/apache/spark/pull/33058#discussion_r657846088



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -58,7 +58,11 @@ trait BroadcastExchangeLike extends Exchange {
    * For registering callbacks on `relationFuture`.
    * Note that calling this method may not start the execution of broadcast job.
    */
-  def completionFuture: scala.concurrent.Future[broadcast.Broadcast[Any]]
+  final def completionFuture: scala.concurrent.Future[broadcast.Broadcast[Any]] = executeQuery {

Review comment:
       This is kind of the AQE version of "execute", as AQE won't call `execute` of shuffle/broadcast.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867644479


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44795/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867788040


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140263/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867644479


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44795/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33058: [SPARK-35874][SQL] AQE Shuffle should wait for its subqueries to finish before materializing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33058:
URL: https://github.com/apache/spark/pull/33058#issuecomment-867600982


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44792/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org