[GitHub] [incubator-inlong] healchow commented on a change in pull request #3447: [INLONG-3428][Manager] Set the default value and code refactor

[GitBox <gi...@apache.org>]

healchow commented on a change in pull request #3447:
URL: https://github.com/apache/incubator-inlong/pull/3447#discussion_r838077563



##########
File path: inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/thirdparty/sort/util/SinkInfoUtils.java
##########
@@ -153,59 +141,29 @@ private static HiveSinkInfo createHiveSinkInfo(HiveSinkResponse hiveInfo, List<F
         } else {
             fileFormat = new HiveSinkInfo.TextFileFormat(separator);
         }
-        // The primary partition field, in Sink must be HiveTimePartitionInfo
-//        List<HivePartitionInfo> partitionList = new ArrayList<>();
-//        String primary = hiveInfo.getPrimaryPartition();
-//        if (StringUtils.isNotEmpty(primary)) {
-//            // Hive partitions are by day, hour, and minute
-//            String unit = hiveInfo.getPartitionUnit();
-//        HiveTimePartitionInfo timePartitionInfo = new HiveTimePartitionInfo(
-//                primary, PARTITION_TIME_FORMAT_MAP.get(unit));
-//            partitionList.add(timePartitionInfo);
-//        }
-        // For the secondary partition field, the sink is temporarily encapsulated as HiveFieldPartitionInfo,
-        // TODO the type be set according to the type of the field itself.
-//        if (StringUtils.isNotEmpty(hiveInfo.getSecondaryPartition())) {
-//            partitionList.add(new HiveSinkInfo.HiveFieldPartitionInfo(hiveInfo.getSecondaryPartition()));
-//        }
 
         // Handle hive partition list
-        List<HivePartitionInfo> partitionList;
-        if (CollectionUtils.isNotEmpty(hiveInfo.getPartitionFieldList())) {
-            checkPartitionField(hiveInfo);
-            hiveInfo.getPartitionFieldList().sort(Comparator.comparing(HivePartitionField::getRankNum));

Review comment:
       Currently, we do not use the rankNum to order the fields.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org