[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #4465: reimplement `push_down_projection` and `prune_column`.

["liukun4515 (via GitHub)" <gi...@apache.org>]

liukun4515 commented on code in PR #4465:
URL: https://github.com/apache/arrow-datafusion/pull/4465#discussion_r1104083184


##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -216,23 +216,24 @@ impl Optimizer {
             // subqueries to joins
             Arc::new(SimplifyExpressions::new()),
             Arc::new(RewriteDisjunctivePredicate::new()),
+            Arc::new(EliminateLimit::new()),
             Arc::new(EliminateFilter::new()),
+            // Filters can't be pushed down past Limits, we should do PushDownFilter after PushDownLimit

Review Comment:
   are there dependencies between some optimization rules?
   
   I don't why we use the same rule twice, such as `PushDownLimit`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org