You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/20 15:01:38 UTC
[GitHub] [flink] matriv opened a new pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
matriv opened a new pull request #17530:
URL: https://github.com/apache/flink/pull/17530
The decimal->boolean cast has been dropped but another PR added some
tests using this cast, removing the casts, and keep only the ones that
cast integer numerics to boolean.
Follows: #32f7cc9e34be67eaf1b746697f2fabefcd5f46c5
Follows: #fc92a8830d07416d37be0ed4c5fe472ac0531c25
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947759705
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 44a40ae5521cc5684ef7a809f6f772c25cb3d779 (Wed Oct 20 15:06:18 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
}, {
"hash" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
* dcfd55678d1aa04a9223d5b7c60e80a4acaa8643 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
}, {
"hash" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
* dcfd55678d1aa04a9223d5b7c60e80a4acaa8643 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
}, {
"hash" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
* dcfd55678d1aa04a9223d5b7c60e80a4acaa8643 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17530:
URL: https://github.com/apache/flink/pull/17530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
}, {
"hash" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
* dcfd55678d1aa04a9223d5b7c60e80a4acaa8643 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
}, {
"hash" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25287",
"triggerID" : "dcfd55678d1aa04a9223d5b7c60e80a4acaa8643",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
* dcfd55678d1aa04a9223d5b7c60e80a4acaa8643 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25287)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17530: [FLINK-24604] Remove tests which use decimal -> boolean cast
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17530:
URL: https://github.com/apache/flink/pull/17530#issuecomment-947758131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284",
"triggerID" : "44a40ae5521cc5684ef7a809f6f772c25cb3d779",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 44a40ae5521cc5684ef7a809f6f772c25cb3d779 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25284)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org