[GitHub] [unomi] sergehuber commented on a change in pull request #202: Return error to the client when exception is thrown from Elasticsearch impl

[GitBox <gi...@apache.org>]

sergehuber commented on a change in pull request #202:
URL: https://github.com/apache/unomi/pull/202#discussion_r520429860



##########
File path: itests/src/test/java/org/apache/unomi/itests/ProfileServiceIT.java
##########
@@ -112,4 +113,25 @@ public void testGetProfileWithScrolling() throws InterruptedException {
         assertEquals(0, profiles.getList().size());
     }
 
+    // Relevant only when throwExceptions system property is true
+    @Test
+    public void testGetProfileWithWrongScrollerIdThrowException() throws InterruptedException {
+        String throwExceptionProperty = System.getProperty("org.apache.unomi.elasticsearch.throwExceptions");

Review comment:
       I suggest we do this in a separate PR because I would like to merge this one. Hope that's ok ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org