You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@karaf.apache.org by Andrei Pozolotin <an...@gmail.com> on 2013/02/14 07:15:18 UTC

pending code review: 4 pull requests

    ***Hello Karaf Developers.**
    *
    I have pending code review: 4 pull requests:

    https://issues.apache.org/jira/browse/KARAF-2183
    https://github.com/ops4j/org.ops4j.pax.url/pull/7

    https://issues.apache.org/jira/browse/KARAF-2173
    https://github.com/apache/karaf/pull/10

    https://issues.apache.org/jira/browse/KARAF-1972
    https://github.com/apache/karaf/pull/11

    https://issues.apache.org/jira/browse/KARAF-2186
    https://github.com/apache/karaf/pull/12

    Can I please get a first-pass response, like
    "yes", "no", "may be", "go away". :-)

    Thank you,

    Andrei

Re: pending code review: 4 pull requests

Posted by Andrei Pozolotin <an...@gmail.com>.

great. looking forward to your feedback.

-------- Original Message --------
Subject: Re: pending code review: 4 pull requests
From: Jean-Baptiste Onofré <jb...@nanthrax.net>
To: dev@karaf.apache.org
Date: Thu 14 Feb 2013 12:25:45 AM CST
> Hi Andrei,
>
> I saw your pull request in the Jira (it's not necessary to send it
> again on the mailing IMHO ;)).
>
> I gonna take a look and provide an update (directly in the Jira). I
> think that bundle:scanner doesn't make sense as dev:watch can be
> enhance (bundle:scanner could be an alias to dev:watch, but one
> command is enough).
>
> Anyway, I will review the Jira.
>
> Regards
> JB
>
> On 02/14/2013 07:15 AM, Andrei Pozolotin wrote:
>>      ***Hello Karaf Developers.**
>>      *
>>      I have pending code review: 4 pull requests:
>>
>>      https://issues.apache.org/jira/browse/KARAF-2183
>>      https://github.com/ops4j/org.ops4j.pax.url/pull/7
>>
>>      https://issues.apache.org/jira/browse/KARAF-2173
>>      https://github.com/apache/karaf/pull/10
>>
>>      https://issues.apache.org/jira/browse/KARAF-1972
>>      https://github.com/apache/karaf/pull/11
>>
>>      https://issues.apache.org/jira/browse/KARAF-2186
>>      https://github.com/apache/karaf/pull/12
>>
>>      Can I please get a first-pass response, like
>>      "yes", "no", "may be", "go away". :-)
>>
>>      Thank you,
>>
>>      Andrei
>>
>>
>

Re: pending code review: 4 pull requests

Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.

Hi Andrei,

I saw your pull request in the Jira (it's not necessary to send it again 
on the mailing IMHO ;)).

I gonna take a look and provide an update (directly in the Jira). I 
think that bundle:scanner doesn't make sense as dev:watch can be enhance 
(bundle:scanner could be an alias to dev:watch, but one command is enough).

Anyway, I will review the Jira.

Regards
JB

On 02/14/2013 07:15 AM, Andrei Pozolotin wrote:
>      ***Hello Karaf Developers.**
>      *
>      I have pending code review: 4 pull requests:
>
>      https://issues.apache.org/jira/browse/KARAF-2183
>      https://github.com/ops4j/org.ops4j.pax.url/pull/7
>
>      https://issues.apache.org/jira/browse/KARAF-2173
>      https://github.com/apache/karaf/pull/10
>
>      https://issues.apache.org/jira/browse/KARAF-1972
>      https://github.com/apache/karaf/pull/11
>
>      https://issues.apache.org/jira/browse/KARAF-2186
>      https://github.com/apache/karaf/pull/12
>
>      Can I please get a first-pass response, like
>      "yes", "no", "may be", "go away". :-)
>
>      Thank you,
>
>      Andrei
>
>

-- 
Jean-Baptiste Onofré
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com