[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #620: Fix HUDI-27 : Support num_cores > 1 for writing through spark

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #620: Fix HUDI-27 : Support num_cores > 1 for writing through spark
URL: https://github.com/apache/incubator-hudi/pull/620#discussion_r270212985
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/io/storage/HoodieWrapperFileSystem.java
 ##########
 @@ -536,8 +536,9 @@ public void completeLocalOutput(Path fsOutputFile, Path tmpLocalFile) throws IOE
   }
 
   @Override
-  public void close() throws IOException {
-    fileSystem.close();
+  public void close() {
 
 Review comment:
   we need shutdown hook only if we open up sockets etc here.. since this just wraps another filesystem. we dont need to do anything special I think 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services