You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2022/03/08 21:24:40 UTC

March releases?

Hi all,

I know I suggested skipping the March releases but I'd like to revisit 
that in light of two things.

1. The concurrency issue I fixed earlier today. [1]
It has been present for a long time and we haven't had any bug reports. 
However, it just looks like a random timeout so users might not report it.
My main motivation is that a customer at $dayjob is affected by this so 
I'd like to get them onto a proper release rather than the snapshot they 
are currently using.

2. The fix for the regression caused by BZ 65757 [2]
No hard evidence for this one, just a general uneasiness about 
regressions in general.

So, thoughts on a set of releases for March?

Mark


[1] 
https://github.com/apache/tomcat/commit/a60528617e512330f91553e925d50a6c34016dd4

[2] 
https://github.com/apache/tomcat/commit/2739565fa5286623e8bb31823770595de14b6370

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: March releases?

Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,

On 3/8/22 16:24, Mark Thomas wrote:
> Hi all,
> 
> I know I suggested skipping the March releases but I'd like to revisit 
> that in light of two things.
> 
> 1. The concurrency issue I fixed earlier today. [1]
> It has been present for a long time and we haven't had any bug reports. 
> However, it just looks like a random timeout so users might not report it.
> My main motivation is that a customer at $dayjob is affected by this so 
> I'd like to get them onto a proper release rather than the snapshot they 
> are currently using.
> 
> 2. The fix for the regression caused by BZ 65757 [2]
> No hard evidence for this one, just a general uneasiness about 
> regressions in general.
> 
> So, thoughts on a set of releases for March?

The Feb releases were so late they were almost March releases. I'm happy 
skipping March but if there's anything anyone is anxious about, I'm also 
happy to roll another one.

-chris

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: March releases?

Posted by Mark Thomas <ma...@apache.org>.
On 08/03/2022 23:54, Konstantin Kolinko wrote:
> ср, 9 мар. 2022 г. в 00:24, Mark Thomas <ma...@apache.org>:
>>
>> Hi all,
>>
>> I know I suggested skipping the March releases but I'd like to revisit
>> that in light of two things.
>>
>> 1. The concurrency issue I fixed earlier today. [1]
>> It has been present for a long time and we haven't had any bug reports.
>> However, it just looks like a random timeout so users might not report it.
>> My main motivation is that a customer at $dayjob is affected by this so
>> I'd like to get them onto a proper release rather than the snapshot they
>> are currently using.
>>
>> 2. The fix for the regression caused by BZ 65757 [2]
>> No hard evidence for this one, just a general uneasiness about
>> regressions in general.
>>
>> So, thoughts on a set of releases for March?
> 
> 1.  The following may be a bug to be addressed before a release:
> See thread "Many IllegalStateException when using http2 protocol"
> - I wonder why the code mentioned there throws an ISE instead of an
> IOException (end of stream exception) when writing to a closed stream.
> That method declares that it throws an IOException. I commented in
> that thread. It is not in BZ yet.
> 
> 2. +1 for rolling a release.

Tx. And Thanks Rémy.

I've fixed the issue above and the open issue in BZ.

I'm currently looking at the unit tests. I saw some failures on Windows 
but I was running on a different VM to usual. I suspect the test ran out 
of ports (my usual VM is configured for more ephemeral ports).

I'll re-run the tests on the usual VM and, if all is well, start tagging.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: March releases?

Posted by Konstantin Kolinko <kn...@gmail.com>.
ср, 9 мар. 2022 г. в 00:24, Mark Thomas <ma...@apache.org>:
>
> Hi all,
>
> I know I suggested skipping the March releases but I'd like to revisit
> that in light of two things.
>
> 1. The concurrency issue I fixed earlier today. [1]
> It has been present for a long time and we haven't had any bug reports.
> However, it just looks like a random timeout so users might not report it.
> My main motivation is that a customer at $dayjob is affected by this so
> I'd like to get them onto a proper release rather than the snapshot they
> are currently using.
>
> 2. The fix for the regression caused by BZ 65757 [2]
> No hard evidence for this one, just a general uneasiness about
> regressions in general.
>
> So, thoughts on a set of releases for March?

1.  The following may be a bug to be addressed before a release:
See thread "Many IllegalStateException when using http2 protocol"
- I wonder why the code mentioned there throws an ISE instead of an
IOException (end of stream exception) when writing to a closed stream.
That method declares that it throws an IOException. I commented in
that thread. It is not in BZ yet.

2. +1 for rolling a release.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: March releases?

Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Mar 8, 2022 at 10:25 PM Mark Thomas <ma...@apache.org> wrote:
>
> Hi all,
>
> I know I suggested skipping the March releases but I'd like to revisit
> that in light of two things.
>
> 1. The concurrency issue I fixed earlier today. [1]
> It has been present for a long time and we haven't had any bug reports.
> However, it just looks like a random timeout so users might not report it.
> My main motivation is that a customer at $dayjob is affected by this so
> I'd like to get them onto a proper release rather than the snapshot they
> are currently using.
>
> 2. The fix for the regression caused by BZ 65757 [2]
> No hard evidence for this one, just a general uneasiness about
> regressions in general.
>
> So, thoughts on a set of releases for March?

No problem, doing a release to fix things is never a bad thing.

Rémy

> Mark
>
>
> [1]
> https://github.com/apache/tomcat/commit/a60528617e512330f91553e925d50a6c34016dd4
>
> [2]
> https://github.com/apache/tomcat/commit/2739565fa5286623e8bb31823770595de14b6370
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org