[GitHub] [hive] aturoczy commented on a diff in pull request #4289: HIVE-27243: Iceberg: Implement Load data via temp table.

["aturoczy (via GitHub)" <gi...@apache.org>]

aturoczy commented on code in PR #4289:
URL: https://github.com/apache/hive/pull/4289#discussion_r1185567260


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java:
##########
@@ -38,7 +38,7 @@
 public class StorageFormat {
 
   private static final Logger LOG = LoggerFactory.getLogger(StorageFormat.class);
-  private static final StorageFormatFactory storageFormatFactory = new StorageFormatFactory();
+  public static final StorageFormatFactory storageFormatFactory = new StorageFormatFactory();

Review Comment:
   It is not better to expose via a getter method?  Like getStorageFromatFactory()



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org