You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@qpid.apache.org by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org> on 2006/12/16 22:12:20 UTC

[jira] Created: (QPID-207) Message.acknowledge() should acknowledge received

Message.acknowledge() should acknowledge received 
--------------------------------------------------

                 Key: QPID-207
                 URL: http://issues.apache.org/jira/browse/QPID-207
             Project: Qpid
          Issue Type: Bug
          Components: Java Client, JMS Compliance
            Reporter: Rob Godfrey
            Priority: Minor


Our current implementation of acknowledge() is such that it acknowledges to the broker all messages received up to the message on which acknowledge is called.

The JMS spec says that acknowledge() should actually acknowledge all messages received on this connection to date.

Since the current functionality is still useful, we should add a new org.apache.qpid.jms.Message interface which extends javax.jms.Message, and add a new method acknowledgeThis() to perform the current functionality.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (QPID-207) Message.acknowledge() should acknowledge received

Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.

     [ http://issues.apache.org/jira/browse/QPID-207?page=all ]

Rob Godfrey updated QPID-207:
-----------------------------

    Attachment: QPID-207.patch

Supplied patch renames existing implementation of acknowledge to ackowledgeThis
Re-implements ackowledge at the Session, which now has to remember the last message to be processed byt any consumer.

unit tests updated and new test cases added

> Message.acknowledge() should acknowledge received
> -------------------------------------------------
>
>                 Key: QPID-207
>                 URL: http://issues.apache.org/jira/browse/QPID-207
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client, JMS Compliance
>            Reporter: Rob Godfrey
>            Priority: Minor
>         Attachments: QPID-207.patch
>
>
> Our current implementation of acknowledge() is such that it acknowledges to the broker all messages received up to the message on which acknowledge is called.
> The JMS spec says that acknowledge() should actually acknowledge all messages received on this connection to date.
> Since the current functionality is still useful, we should add a new org.apache.qpid.jms.Message interface which extends javax.jms.Message, and add a new method acknowledgeThis() to perform the current functionality.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Assigned: (QPID-207) Message.acknowledge() should acknowledge received

Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.

     [ https://issues.apache.org/jira/browse/QPID-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Godfrey reassigned QPID-207:
--------------------------------

    Assignee: Rob Godfrey

> Message.acknowledge() should acknowledge received
> -------------------------------------------------
>
>                 Key: QPID-207
>                 URL: https://issues.apache.org/jira/browse/QPID-207
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client, JMS Compliance
>            Reporter: Rob Godfrey
>         Assigned To: Rob Godfrey
>            Priority: Minor
>             Fix For: M2
>
>         Attachments: QPID-207.patch
>
>
> Our current implementation of acknowledge() is such that it acknowledges to the broker all messages received up to the message on which acknowledge is called.
> The JMS spec says that acknowledge() should actually acknowledge all messages received on this connection to date.
> Since the current functionality is still useful, we should add a new org.apache.qpid.jms.Message interface which extends javax.jms.Message, and add a new method acknowledgeThis() to perform the current functionality.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (QPID-207) Message.acknowledge() should acknowledge received

Posted by "Robert Greig (JIRA)" <qp...@incubator.apache.org>.

     [ http://issues.apache.org/jira/browse/QPID-207?page=all ]

Robert Greig resolved QPID-207.
-------------------------------

    Fix Version/s: M2
       Resolution: Fixed

Committed as svn revision 487903

> Message.acknowledge() should acknowledge received
> -------------------------------------------------
>
>                 Key: QPID-207
>                 URL: http://issues.apache.org/jira/browse/QPID-207
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Client, JMS Compliance
>            Reporter: Rob Godfrey
>            Priority: Minor
>             Fix For: M2
>
>         Attachments: QPID-207.patch
>
>
> Our current implementation of acknowledge() is such that it acknowledges to the broker all messages received up to the message on which acknowledge is called.
> The JMS spec says that acknowledge() should actually acknowledge all messages received on this connection to date.
> Since the current functionality is still useful, we should add a new org.apache.qpid.jms.Message interface which extends javax.jms.Message, and add a new method acknowledgeThis() to perform the current functionality.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira