You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/26 10:38:51 UTC
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request
#3809: Revert PR#3663
KomachiSion opened a new pull request #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809
Revert reason, the PR causes the new issue #3770 .
I think we need to revert and use DDL of encrypt to fix #2884 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
KomachiSion commented on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569036477
HI @xiyelife , After the PR merged, there are some error for you added in #3768 .
Can you update the test case so that it can run correctly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue
#3809: Revert PR#3663
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569042083
@xiyelife Hi boy, we need your support. This issue blocks our coming release!
This PR rollbacks one commit to solve #3770 , which makes one unit test in [your PR](https://github.com/apache/incubator-shardingsphere/pull/3768) perform wrong .
Currenty we have to ignore this unit test, so could you give a look at it and make it run well again?
Looking forward to your reply, Thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
xiyelife commented on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569056656
@tristaZero yeah, I can make my pr https://github.com/apache/incubator-shardingsphere/pull/3768 run well, but how to do it with this revert PR and waiting for it has been merged to dev , then submit a new PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue
#3809: Revert PR#3663
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569042083
@xiyelife Hi boy, we need your support. This issue blocks our coming release!
This PR rollbacks one commit to solve #3770 , which makes one unit test in [your PR](https://github.com/apache/incubator-shardingsphere/pull/3768) run wrong .
Currenty we have to ignore this unit test, so could you give a look at it and make it run well again?
Looking forward to your reply, Thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
KomachiSion commented on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569163556
> @KomachiSion when your revert PR is merged, I'll sumbit a new PR to fixed it and add my unit test back.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] xiyelife commented on issue #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
xiyelife commented on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569161169
@KomachiSion when your revert PR is merged, I'll sumbit a new PR to fixed it and add my unit test back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569170407
@xiyelife Hi sir, i notice that you have do a few of contributions to shardingsphere community. Very appreciated your effort.
Just out of my curiosity, do you enjoy it and also want to do more to this community? From my side, you are energetic and have a bit clear understand of sharding sphere. So i am expecting your successive interactions in sharding sphere community and to be our committer one day. Good luck and welcome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569165334
@xiyelife Hi so now It’s your turn. :）
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
KomachiSion commented on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569158355
> @tristaZero yeah, I can make my pr #3768 run well, but how to do it with this revert PR and waiting for it has been merged to dev , then submit a new PR?
Yes, after this pr merged, init table SQL `INSERT INTO t_encrypt_contains_column VALUES(1, 'cipherValue', 'plainValue', 'cipherValue', 'plainValue')` will execute error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue
#3809: Revert PR#3663
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569042083
@xiyelife Hi boy, we need your support. This issue blocks our coming release!
This PR rollbacks one commit to solve #3770 , however one unit test in [your PR](https://github.com/apache/incubator-shardingsphere/pull/3768) can not run well.
Currenty we have to ignore this unit test, so could you give a look at it and make it run well again?
Looking forward to your reply, Thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue
#3809: Revert PR#3663
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569170407
@xiyelife Hi sir, i notice that you have do a few of contributions to shardingsphere community. Very appreciated your effort.
Just out of my curiosity, do you enjoy it and also want to do more to this community? From my side, you are energetic and have a bit clear understand of sharding sphere. So i am expecting your successive interactions in sharding sphere community and to be Apache committer one day. Good luck and welcome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3809:
Revert PR#3663
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #3809: Revert PR#3663
URL: https://github.com/apache/incubator-shardingsphere/pull/3809#issuecomment-569042083
@xiyelife Hi boy, we need your support. This issue blocks our coming release!
This PR rollbacks one commit to solve #3770 , however one unit test in (your PR)[https://github.com/apache/incubator-shardingsphere/pull/3768] can not run well.
Currenty we have to ignore this unit test, so could you give a look at it and make it run well again?
Looking forward to your reply, Thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services