You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by cb...@apache.org on 2011/11/17 13:10:34 UTC

svn commit: r1203163 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java test/java/org/apache/fop/fonts/truetype/TTFFontLoaderTestCase.java

Author: cbowditch
Date: Thu Nov 17 12:10:34 2011
New Revision: 1203163

URL: http://svn.apache.org/viewvc?rev=1203163&view=rev
Log:
Bugzilla #51592: TTFFontLoader ignores the useKerning attribute used with fonts
Patch submitted by Mehdi Houshmand (mehdi1985 at gmail.com)

Added:
    xmlgraphics/fop/trunk/test/java/org/apache/fop/fonts/truetype/TTFFontLoaderTestCase.java
Modified:
    xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java?rev=1203163&r1=1203162&r2=1203163&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/fonts/truetype/TTFFontLoader.java Thu Nov 17 12:10:34 2011
@@ -70,7 +70,7 @@ public class TTFFontLoader extends FontL
     public TTFFontLoader(String fontFileURI, String subFontName,
                 boolean embedded, EncodingMode encodingMode, boolean useKerning,
                 FontResolver resolver) {
-        super(fontFileURI, embedded, true, resolver);
+        super(fontFileURI, embedded, useKerning, resolver);
         this.subFontName = subFontName;
         this.encodingMode = encodingMode;
         if (this.encodingMode == EncodingMode.AUTO) {

Added: xmlgraphics/fop/trunk/test/java/org/apache/fop/fonts/truetype/TTFFontLoaderTestCase.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/test/java/org/apache/fop/fonts/truetype/TTFFontLoaderTestCase.java?rev=1203163&view=auto
==============================================================================
--- xmlgraphics/fop/trunk/test/java/org/apache/fop/fonts/truetype/TTFFontLoaderTestCase.java (added)
+++ xmlgraphics/fop/trunk/test/java/org/apache/fop/fonts/truetype/TTFFontLoaderTestCase.java Thu Nov 17 12:10:34 2011
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* $Id$ */
+
+package org.apache.fop.fonts.truetype;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.junit.Test;
+
+import org.apache.fop.fonts.EncodingMode;
+import org.apache.fop.fonts.FontManager;
+import org.apache.fop.fonts.FontResolver;
+
+/**
+ * Test case for {@link TTFFontLoader}.
+ */
+public class TTFFontLoaderTestCase {
+
+    @Test
+    public void testUseKerning() throws IOException {
+        File file = new File("test/resources/fonts/DejaVuLGCSerif.ttf");
+        String absoluteFilePath = file.toURL().toExternalForm();
+        FontResolver resolver = FontManager.createMinimalFontResolver();
+        String fontName = "Deja Vu";
+        boolean embedded = false;
+        boolean useKerning = true;
+
+        TTFFontLoader fontLoader = new TTFFontLoader(absoluteFilePath, fontName, embedded,
+                EncodingMode.AUTO, useKerning, resolver);
+        assertTrue(fontLoader.getFont().hasKerningInfo());
+        useKerning = false;
+
+        fontLoader = new TTFFontLoader(absoluteFilePath, fontName, embedded, EncodingMode.AUTO,
+                useKerning, resolver);
+        assertFalse(fontLoader.getFont().hasKerningInfo());
+    }
+}
\ No newline at end of file



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org