[jira] [Commented] (LUCENE-6959) Remove ToParentBlockJoinCollector

["Martijn van Groningen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15836779#comment-15836779 ] 

Martijn van Groningen commented on LUCENE-6959:
-----------------------------------------------

+1 To remove this collector in the master and 6x branches.

As a follow up issue we can add back to ability to include child docs, but in a different way than is done today. A subsequent search after the main search, that selects child docs for specific parents. For example like is done here: https://github.com/elastic/elasticsearch/blob/master/core/src/main/java/org/elasticsearch/search/fetch/subphase/InnerHitsContext.java#L160

> Remove ToParentBlockJoinCollector
> ---------------------------------
>
>                 Key: LUCENE-6959
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6959
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6959.patch
>
>
> This collector uses the getWeight() and getChildren() methods from the passed in Scorer, which are not always available (eg. disjunctions expose fake scorers) hence the need for a dedicated IndexSearcher (ToParentBlockJoinIndexSearcher). Given that this is the only collector in this case, I would like to remove it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org