You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by Andreas Beeker <ki...@apache.org> on 2017/04/01 22:46:16 UTC
POI 3.16 Final?
Hi,
how about pushing the 3.16 final out soon?
I have quite a few changes for HPSF, which I don't want to commit to the final.
Who will be the release manager? ... I'll be the fallback, if everyone is busy ...
Andi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
RE: POI 3.16 Final?
Posted by "Allison, Timothy B." <ta...@mitre.org>.
Hi Andi,
I added a try/catch block (r1790904). In the catch block I apply win1252, like we used to do. This reverts to our old behavior if there's a length exception.
I'm still not happy with this hack, but I think we're doing better than we were and we're good enough to go.
We also still have https://bz.apache.org/bugzilla/show_bug.cgi?id=60952 open for follow on work.
For clarification, when you say property sets...do you mean the Document Properties from the tablestream?
Onward. Thank you!
Best,
Tim
-----Original Message-----
From: Andreas Beeker [mailto:kiwiwings@apache.org]
Sent: Monday, April 10, 2017 7:03 PM
To: POI Developers List <de...@poi.apache.org>
Subject: Re: POI 3.16 Final?
Hi Tim,
I'm waiting for your go to start with the candidate.
Not sure, if this of any help, but the property sets also contain a codepage and this might help in guessing the codepage in HWPFOldDocument.guessCodePage().
Andi
On 10.04.2017 22:28, Dominik Stadler wrote:
> Hi Tim,
>
> I have now updated the results to include links to one sample file for
> each failure in the rightmost column in the table, let me know if you
> need more samples for certain failures, I can fairly easily pull them
> from the database if needed.
>
> Dominik.
>
> On Mon, Apr 10, 2017 at 4:07 PM, Allison, Timothy B.
> <ta...@mitre.org>
> wrote:
>
>> Thank you, Dominik!
>>
>> Is there any way I can get the HWPFOld documents?
>>
>> Also, are you able to tell which files are now going oom? Is that a
>> fluke of the run or is that a new bug?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org
RE: POI 3.16 Final?
Posted by "Allison, Timothy B." <ta...@mitre.org>.
Thank you! I'm looking at a file from Dominik's updated links now.
-----Original Message-----
From: Andreas Beeker [mailto:kiwiwings@apache.org]
Sent: Monday, April 10, 2017 7:03 PM
To: POI Developers List <de...@poi.apache.org>
Subject: Re: POI 3.16 Final?
Hi Tim,
I'm waiting for your go to start with the candidate.
Not sure, if this of any help, but the property sets also contain a codepage and this might help in guessing the codepage in HWPFOldDocument.guessCodePage().
Andi
On 10.04.2017 22:28, Dominik Stadler wrote:
> Hi Tim,
>
> I have now updated the results to include links to one sample file for
> each failure in the rightmost column in the table, let me know if you
> need more samples for certain failures, I can fairly easily pull them
> from the database if needed.
>
> Dominik.
>
> On Mon, Apr 10, 2017 at 4:07 PM, Allison, Timothy B.
> <ta...@mitre.org>
> wrote:
>
>> Thank you, Dominik!
>>
>> Is there any way I can get the HWPFOld documents?
>>
>> Also, are you able to tell which files are now going oom? Is that a
>> fluke of the run or is that a new bug?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org
Re: POI 3.16 Final?
Posted by Andreas Beeker <ki...@apache.org>.
Hi Tim,
I'm waiting for your go to start with the candidate.
Not sure, if this of any help, but the property sets also contain a codepage
and this might help in guessing the codepage in HWPFOldDocument.guessCodePage().
Andi
On 10.04.2017 22:28, Dominik Stadler wrote:
> Hi Tim,
>
> I have now updated the results to include links to one sample file for each
> failure in the rightmost column in the table, let me know if you need more
> samples for certain failures, I can fairly easily pull them from the
> database if needed.
>
> Dominik.
>
> On Mon, Apr 10, 2017 at 4:07 PM, Allison, Timothy B. <ta...@mitre.org>
> wrote:
>
>> Thank you, Dominik!
>>
>> Is there any way I can get the HWPFOld documents?
>>
>> Also, are you able to tell which files are now going oom? Is that a fluke
>> of the run or is that a new bug?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: POI 3.16 Final?
Posted by Dominik Stadler <do...@gmx.at>.
Hi Tim,
I have now updated the results to include links to one sample file for each
failure in the rightmost column in the table, let me know if you need more
samples for certain failures, I can fairly easily pull them from the
database if needed.
Dominik.
On Mon, Apr 10, 2017 at 4:07 PM, Allison, Timothy B. <ta...@mitre.org>
wrote:
> Thank you, Dominik!
>
> Is there any way I can get the HWPFOld documents?
>
> Also, are you able to tell which files are now going oom? Is that a fluke
> of the run or is that a new bug?
>
>
> -----Original Message-----
> From: Dominik Stadler [mailto:dominik.stadler@gmx.at]
> Sent: Sunday, April 9, 2017 2:14 PM
> To: POI Developers List <de...@poi.apache.org>
> Subject: Re: POI 3.16 Final?
>
> Hi,
>
> regression tests are in, I compared it to 3.15-FINAL, see 3.15-RC2 to
> 3.16-beta3
> <http://people.apache.org/%7Ecentic/poi_regression/
> reports/index315RC2to316beta3.html>,
> all failures in the corpus are at 3.16-beta3-All <
> http://people.apache.org/%7Ecentic/poi_regression/reportsAll/
> index315RC2to316beta3.html>,
> we have around 22.5k that work now compared to 3.16-beta2 and aprox. 1000
> compared to 3.16-beta2.
>
> There are a few regressions compared to 3.15 that happen quite rarely,
> some because we do more with pictures now and some due to more support for
> old word documents, both look like not actual regressions, but more like
> new failures in newly exhibited code.
>
>
> Dominik.
>
>
>
> On Tue, Apr 4, 2017 at 8:52 AM, Javen O'Neal <on...@apache.org> wrote:
>
> > +1
> >
> > ThreadLocal-related bugs:
> > https://bz.apache.org/bugzilla/buglist.cgi?bug_status=__all__&content=
> > Threadlocal&list_id=158556&order=Importance&product=POI&
> > query_format=specific
> >
> > On Apr 3, 2017 8:15 AM, "Dominik Stadler" <do...@gmx.at>
> wrote:
> >
> > > Hi,
> > >
> > > soonish sounds fine to me, I can start a first regression run
> > > tomorrow or Wednesday to get results before we start the release
> process.
> > >
> > > On ThreadLocals: XMLBeans is dormant, so unfortuantely not much help
> > > to
> > be
> > > expected from there, I started some early work on
> > > https://bz.apache.org/
> > > bugzilla/show_bug.cgi?id=59268 some time ago, but unfortunately it
> > > was very unwieldly, i.e. for some reason it was hard to even
> > > identify the exact version used for previous releases or build the
> > > latest version cleanly.
> > >
> > > Dominik.
> > >
> > > On Mon, Apr 3, 2017 at 3:14 PM, Allison, Timothy B.
> > > <ta...@mitre.org>
> > > wrote:
> > >
> > > > Is there anything we can do about ThreadLocal leaks in POI bug
> > > > 55149/XMLBEANS-502/TIKA-1784?
> > > >
> > > > -----Original Message-----
> > > > From: Allison, Timothy B. [mailto:tallison@mitre.org]
> > > > Sent: Monday, April 3, 2017 9:06 AM
> > > > To: POI Developers List <de...@poi.apache.org>
> > > > Subject: RE: POI 3.16 Final?
> > > >
> > > > +1 for next couple days-ish.
> > > >
> > > > I'd like to finish or abandon hope on 50955. I'll be working on
> > > > that
> > > this
> > > > morning.
> > > >
> > > > -----Original Message-----
> > > > From: Andreas Beeker [mailto:kiwiwings@apache.org]
> > > > Sent: Saturday, April 1, 2017 6:46 PM
> > > > To: POI Developers List <de...@poi.apache.org>
> > > > Subject: POI 3.16 Final?
> > > >
> > > > Hi,
> > > >
> > > > how about pushing the 3.16 final out soon?
> > > >
> > > > I have quite a few changes for HPSF, which I don't want to commit
> > > > to
> > the
> > > > final.
> > > >
> > > > Who will be the release manager? ... I'll be the fallback, if
> > > > everyone
> > is
> > > > busy ...
> > > >
> > > > Andi
> > > >
> > > >
> > > > ------------------------------------------------------------------
> > > > --- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For
> > > > additional commands, e-mail: dev-help@poi.apache.org
> > > >
> > > >
> > > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>
RE: POI 3.16 Final?
Posted by "Allison, Timothy B." <ta...@mitre.org>.
Thank you, Dominik!
Is there any way I can get the HWPFOld documents?
Also, are you able to tell which files are now going oom? Is that a fluke of the run or is that a new bug?
-----Original Message-----
From: Dominik Stadler [mailto:dominik.stadler@gmx.at]
Sent: Sunday, April 9, 2017 2:14 PM
To: POI Developers List <de...@poi.apache.org>
Subject: Re: POI 3.16 Final?
Hi,
regression tests are in, I compared it to 3.15-FINAL, see 3.15-RC2 to
3.16-beta3
<http://people.apache.org/%7Ecentic/poi_regression/reports/index315RC2to316beta3.html>,
all failures in the corpus are at 3.16-beta3-All <http://people.apache.org/%7Ecentic/poi_regression/reportsAll/index315RC2to316beta3.html>,
we have around 22.5k that work now compared to 3.16-beta2 and aprox. 1000 compared to 3.16-beta2.
There are a few regressions compared to 3.15 that happen quite rarely, some because we do more with pictures now and some due to more support for old word documents, both look like not actual regressions, but more like new failures in newly exhibited code.
Dominik.
On Tue, Apr 4, 2017 at 8:52 AM, Javen O'Neal <on...@apache.org> wrote:
> +1
>
> ThreadLocal-related bugs:
> https://bz.apache.org/bugzilla/buglist.cgi?bug_status=__all__&content=
> Threadlocal&list_id=158556&order=Importance&product=POI&
> query_format=specific
>
> On Apr 3, 2017 8:15 AM, "Dominik Stadler" <do...@gmx.at> wrote:
>
> > Hi,
> >
> > soonish sounds fine to me, I can start a first regression run
> > tomorrow or Wednesday to get results before we start the release process.
> >
> > On ThreadLocals: XMLBeans is dormant, so unfortuantely not much help
> > to
> be
> > expected from there, I started some early work on
> > https://bz.apache.org/
> > bugzilla/show_bug.cgi?id=59268 some time ago, but unfortunately it
> > was very unwieldly, i.e. for some reason it was hard to even
> > identify the exact version used for previous releases or build the
> > latest version cleanly.
> >
> > Dominik.
> >
> > On Mon, Apr 3, 2017 at 3:14 PM, Allison, Timothy B.
> > <ta...@mitre.org>
> > wrote:
> >
> > > Is there anything we can do about ThreadLocal leaks in POI bug
> > > 55149/XMLBEANS-502/TIKA-1784?
> > >
> > > -----Original Message-----
> > > From: Allison, Timothy B. [mailto:tallison@mitre.org]
> > > Sent: Monday, April 3, 2017 9:06 AM
> > > To: POI Developers List <de...@poi.apache.org>
> > > Subject: RE: POI 3.16 Final?
> > >
> > > +1 for next couple days-ish.
> > >
> > > I'd like to finish or abandon hope on 50955. I'll be working on
> > > that
> > this
> > > morning.
> > >
> > > -----Original Message-----
> > > From: Andreas Beeker [mailto:kiwiwings@apache.org]
> > > Sent: Saturday, April 1, 2017 6:46 PM
> > > To: POI Developers List <de...@poi.apache.org>
> > > Subject: POI 3.16 Final?
> > >
> > > Hi,
> > >
> > > how about pushing the 3.16 final out soon?
> > >
> > > I have quite a few changes for HPSF, which I don't want to commit
> > > to
> the
> > > final.
> > >
> > > Who will be the release manager? ... I'll be the fallback, if
> > > everyone
> is
> > > busy ...
> > >
> > > Andi
> > >
> > >
> > > ------------------------------------------------------------------
> > > --- To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For
> > > additional commands, e-mail: dev-help@poi.apache.org
> > >
> > >
> > >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: POI 3.16 Final?
Posted by kiwiwings <ki...@apache.org>.
The errors don't look like blockers to me, so I try to fix the Extractor
errors
tonight - if they are no-brainers - and build the release candidate
afterwards.
If they involve more substantial rework, I guess it's ok to release (the
candidate) without the fix.
Andi
--
View this message in context: http://apache-poi.1045710.n5.nabble.com/POI-3-16-Final-tp5727121p5727191.html
Sent from the POI - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: POI 3.16 Final?
Posted by Dominik Stadler <do...@gmx.at>.
Hi,
regression tests are in, I compared it to 3.15-FINAL, see 3.15-RC2 to
3.16-beta3
<http://people.apache.org/%7Ecentic/poi_regression/reports/index315RC2to316beta3.html>,
all failures in the corpus are at 3.16-beta3-All
<http://people.apache.org/%7Ecentic/poi_regression/reportsAll/index315RC2to316beta3.html>,
we have around 22.5k that work now compared to 3.16-beta2 and aprox. 1000
compared to 3.16-beta2.
There are a few regressions compared to 3.15 that happen quite rarely, some
because we do more with pictures now and some due to more support for old
word documents, both look like not actual regressions, but more like new
failures in newly exhibited code.
Dominik.
On Tue, Apr 4, 2017 at 8:52 AM, Javen O'Neal <on...@apache.org> wrote:
> +1
>
> ThreadLocal-related bugs:
> https://bz.apache.org/bugzilla/buglist.cgi?bug_status=__all__&content=
> Threadlocal&list_id=158556&order=Importance&product=POI&
> query_format=specific
>
> On Apr 3, 2017 8:15 AM, "Dominik Stadler" <do...@gmx.at> wrote:
>
> > Hi,
> >
> > soonish sounds fine to me, I can start a first regression run tomorrow or
> > Wednesday to get results before we start the release process.
> >
> > On ThreadLocals: XMLBeans is dormant, so unfortuantely not much help to
> be
> > expected from there, I started some early work on https://bz.apache.org/
> > bugzilla/show_bug.cgi?id=59268 some time ago, but unfortunately it was
> > very
> > unwieldly, i.e. for some reason it was hard to even identify the exact
> > version used for previous releases or build the latest version cleanly.
> >
> > Dominik.
> >
> > On Mon, Apr 3, 2017 at 3:14 PM, Allison, Timothy B. <ta...@mitre.org>
> > wrote:
> >
> > > Is there anything we can do about ThreadLocal leaks in POI bug
> > > 55149/XMLBEANS-502/TIKA-1784?
> > >
> > > -----Original Message-----
> > > From: Allison, Timothy B. [mailto:tallison@mitre.org]
> > > Sent: Monday, April 3, 2017 9:06 AM
> > > To: POI Developers List <de...@poi.apache.org>
> > > Subject: RE: POI 3.16 Final?
> > >
> > > +1 for next couple days-ish.
> > >
> > > I'd like to finish or abandon hope on 50955. I'll be working on that
> > this
> > > morning.
> > >
> > > -----Original Message-----
> > > From: Andreas Beeker [mailto:kiwiwings@apache.org]
> > > Sent: Saturday, April 1, 2017 6:46 PM
> > > To: POI Developers List <de...@poi.apache.org>
> > > Subject: POI 3.16 Final?
> > >
> > > Hi,
> > >
> > > how about pushing the 3.16 final out soon?
> > >
> > > I have quite a few changes for HPSF, which I don't want to commit to
> the
> > > final.
> > >
> > > Who will be the release manager? ... I'll be the fallback, if everyone
> is
> > > busy ...
> > >
> > > Andi
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional
> > > commands, e-mail: dev-help@poi.apache.org
> > >
> > >
> > >
> >
>
Re: POI 3.16 Final?
Posted by Javen O'Neal <on...@apache.org>.
+1
ThreadLocal-related bugs:
https://bz.apache.org/bugzilla/buglist.cgi?bug_status=__all__&content=Threadlocal&list_id=158556&order=Importance&product=POI&query_format=specific
On Apr 3, 2017 8:15 AM, "Dominik Stadler" <do...@gmx.at> wrote:
> Hi,
>
> soonish sounds fine to me, I can start a first regression run tomorrow or
> Wednesday to get results before we start the release process.
>
> On ThreadLocals: XMLBeans is dormant, so unfortuantely not much help to be
> expected from there, I started some early work on https://bz.apache.org/
> bugzilla/show_bug.cgi?id=59268 some time ago, but unfortunately it was
> very
> unwieldly, i.e. for some reason it was hard to even identify the exact
> version used for previous releases or build the latest version cleanly.
>
> Dominik.
>
> On Mon, Apr 3, 2017 at 3:14 PM, Allison, Timothy B. <ta...@mitre.org>
> wrote:
>
> > Is there anything we can do about ThreadLocal leaks in POI bug
> > 55149/XMLBEANS-502/TIKA-1784?
> >
> > -----Original Message-----
> > From: Allison, Timothy B. [mailto:tallison@mitre.org]
> > Sent: Monday, April 3, 2017 9:06 AM
> > To: POI Developers List <de...@poi.apache.org>
> > Subject: RE: POI 3.16 Final?
> >
> > +1 for next couple days-ish.
> >
> > I'd like to finish or abandon hope on 50955. I'll be working on that
> this
> > morning.
> >
> > -----Original Message-----
> > From: Andreas Beeker [mailto:kiwiwings@apache.org]
> > Sent: Saturday, April 1, 2017 6:46 PM
> > To: POI Developers List <de...@poi.apache.org>
> > Subject: POI 3.16 Final?
> >
> > Hi,
> >
> > how about pushing the 3.16 final out soon?
> >
> > I have quite a few changes for HPSF, which I don't want to commit to the
> > final.
> >
> > Who will be the release manager? ... I'll be the fallback, if everyone is
> > busy ...
> >
> > Andi
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional
> > commands, e-mail: dev-help@poi.apache.org
> >
> >
> >
>
Re: POI 3.16 Final?
Posted by Dominik Stadler <do...@gmx.at>.
Hi,
soonish sounds fine to me, I can start a first regression run tomorrow or
Wednesday to get results before we start the release process.
On ThreadLocals: XMLBeans is dormant, so unfortuantely not much help to be
expected from there, I started some early work on https://bz.apache.org/
bugzilla/show_bug.cgi?id=59268 some time ago, but unfortunately it was very
unwieldly, i.e. for some reason it was hard to even identify the exact
version used for previous releases or build the latest version cleanly.
Dominik.
On Mon, Apr 3, 2017 at 3:14 PM, Allison, Timothy B. <ta...@mitre.org>
wrote:
> Is there anything we can do about ThreadLocal leaks in POI bug
> 55149/XMLBEANS-502/TIKA-1784?
>
> -----Original Message-----
> From: Allison, Timothy B. [mailto:tallison@mitre.org]
> Sent: Monday, April 3, 2017 9:06 AM
> To: POI Developers List <de...@poi.apache.org>
> Subject: RE: POI 3.16 Final?
>
> +1 for next couple days-ish.
>
> I'd like to finish or abandon hope on 50955. I'll be working on that this
> morning.
>
> -----Original Message-----
> From: Andreas Beeker [mailto:kiwiwings@apache.org]
> Sent: Saturday, April 1, 2017 6:46 PM
> To: POI Developers List <de...@poi.apache.org>
> Subject: POI 3.16 Final?
>
> Hi,
>
> how about pushing the 3.16 final out soon?
>
> I have quite a few changes for HPSF, which I don't want to commit to the
> final.
>
> Who will be the release manager? ... I'll be the fallback, if everyone is
> busy ...
>
> Andi
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional
> commands, e-mail: dev-help@poi.apache.org
>
>
>
RE: POI 3.16 Final?
Posted by "Allison, Timothy B." <ta...@mitre.org>.
Is there anything we can do about ThreadLocal leaks in POI bug 55149/XMLBEANS-502/TIKA-1784?
-----Original Message-----
From: Allison, Timothy B. [mailto:tallison@mitre.org]
Sent: Monday, April 3, 2017 9:06 AM
To: POI Developers List <de...@poi.apache.org>
Subject: RE: POI 3.16 Final?
+1 for next couple days-ish.
I'd like to finish or abandon hope on 50955. I'll be working on that this morning.
-----Original Message-----
From: Andreas Beeker [mailto:kiwiwings@apache.org]
Sent: Saturday, April 1, 2017 6:46 PM
To: POI Developers List <de...@poi.apache.org>
Subject: POI 3.16 Final?
Hi,
how about pushing the 3.16 final out soon?
I have quite a few changes for HPSF, which I don't want to commit to the final.
Who will be the release manager? ... I'll be the fallback, if everyone is busy ...
Andi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org
RE: POI 3.16 Final?
Posted by "Allison, Timothy B." <ta...@mitre.org>.
+1 for next couple days-ish.
I'd like to finish or abandon hope on 50955. I'll be working on that this morning.
-----Original Message-----
From: Andreas Beeker [mailto:kiwiwings@apache.org]
Sent: Saturday, April 1, 2017 6:46 PM
To: POI Developers List <de...@poi.apache.org>
Subject: POI 3.16 Final?
Hi,
how about pushing the 3.16 final out soon?
I have quite a few changes for HPSF, which I don't want to commit to the final.
Who will be the release manager? ... I'll be the fallback, if everyone is busy ...
Andi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org For additional commands, e-mail: dev-help@poi.apache.org