You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by Skiler <gi...@git.apache.org> on 2017/12/06 14:52:33 UTC
[GitHub] activemq-artemis pull request #1690: ARTEMIS-1523 Allow MQTT with dynamic cl...
GitHub user Skiler opened a pull request:
https://github.com/apache/activemq-artemis/pull/1690
ARTEMIS-1523 Allow MQTT with dynamic cluster
ARTEMIS-1523 Allow MQTT with dynamic cluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Skiler/activemq-artemis mqqtcluster
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1690
----
commit c1e2d1472b6060117f9c64aad066f48324300201
Author: raul.valdoleiros <ra...@ceiia.com>
Date: 2017-11-24T17:53:14Z
ARTEMIS-1523 Allow MQTT with dynamic cluster
ARTEMIS-1523 Allow MQTT with dynamic cluster
----
---
[GitHub] activemq-artemis issue #1690: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1690
@michaelandrepearce, I'm working on this PR with @Skiler. I plan on amending it before merging to deal with all the stuff you mentioned (plus a few other things).
---
[GitHub] activemq-artemis issue #1690: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1690
@jbertram great cheers for that.
---
[GitHub] activemq-artemis pull request #1690: ARTEMIS-1523 Allow MQTT with dynamic cl...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1690#discussion_r155677138
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/WildcardAddressManager.java ---
@@ -30,6 +25,11 @@
import org.apache.activemq.artemis.core.postoffice.BindingsFactory;
import org.apache.activemq.artemis.core.transaction.Transaction;
+import java.util.Collection;
--- End diff --
This move re-change wasn't needed, if could revert, so just the code changes needed are in the PR.
---
[GitHub] activemq-artemis issue #1690: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by Skiler <gi...@git.apache.org>.
Github user Skiler commented on the issue:
https://github.com/apache/activemq-artemis/pull/1690
Hi @jbertram
This is the new pull request. It's possible to include this fix in the 2.4.0 version?
Thanks
---
[GitHub] activemq-artemis pull request #1690: ARTEMIS-1523 Allow MQTT with dynamic cl...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1690
---
[GitHub] activemq-artemis pull request #1690: ARTEMIS-1523 Allow MQTT with dynamic cl...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1690#discussion_r155676188
--- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTPublishManager.java ---
@@ -5,9 +5,9 @@
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
- *
+ * <p>
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ * <p>
--- End diff --
<p> should not be added
---
[GitHub] activemq-artemis issue #1690: ARTEMIS-1523 Allow MQTT with dynamic cluster
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/1690
@Skiler, btw this will go into 2.5.0 since 2.4.0 has already been released.
---
[GitHub] activemq-artemis pull request #1690: ARTEMIS-1523 Allow MQTT with dynamic cl...
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1690#discussion_r155676825
--- Diff: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTPublishManager.java ---
@@ -5,9 +5,9 @@
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
- *
+ * <p>
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ * <p>
--- End diff --
On that note, there doesn't seem to be any material change to this class, except you've used a re-formatter set to your own settings, id suggest simply reverting this file.
---