You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/02 22:45:01 UTC

[GitHub] [maven-surefire] Tibor17 opened a new pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Tibor17 opened a new pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426


   This helps us fixing JDK 18 issue (see the PR #422 and #424) regarding deprecated [SecurityManager](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/SecurityManager.html).
   
   Additionally, the project will reference own versions only.
   
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1008157885


   I made it working ;-)
   But the profile `apache-release` is not dedicated for SNAPSHOTS. Only for releases.
   Yeah, I had to turn `distributionManagement.repository.id` to `distributionManagement.snapshotRepository.id` but it is done to confirm that the GnuPG plugin works as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] slawekjaranowski commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1007231317


   Next issue what i see:
   `install:install-file` creates and install empty pom for `surefire-shared-utils..jar` it is done in install phase ... so probably additional pom will be not signed by gpg during release
   
   I don't know if will be possible release to Central repository without signatures.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1006964448


   @slawekjaranowski
   
   I was able to avoid  `build-helper-maven-plugin` and used the trick with setting properties (`distRepoId`, `distRepoUrl`) for snapshots by default and for release versions as well. The other two plugins could not be avoided. This works fine with IntelliJ IDEA/ Eclipse. The solution previously used with a classifier did not work with IDEA - red lines in the import section and hanging tests in the module `surefire-booter`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1003791250


   @slawekjaranowski
   @eolivelli
   I will try to make one more alternative without these ugly plugins (install, deploy, build-helper) similar to what we had several years ago with several exceptions that now the classes will not be duplicated in all JAR files and the `surefire-shared-utils` artifact will exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1012337760


   @slawekjaranowski
   The profile `apache-release` cannot be used together with tests by default because the contributors will see crashed `maven-gpg-plugin`. I guess all you wanted to say was that the checksums SHA-512 are needed, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 removed a comment on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 removed a comment on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1003791250


   @slawekjaranowski
   @eolivelli
   I will try to make one more alternative without these ugly plugins (install, deploy, build-helper) similar to what we had several years ago with several exceptions that now the external classes will not be included/duplicate in all JAR files and the `surefire-shared-utils` artifact will exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] slawekjaranowski commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1008076050


   It is not signed ....
   
   ```
    mvn clean install -pl surefire-shared -P apache-release
   ```
   
   in local repo I have:
   
   ```
   $ ls -l ~/.m2/repository/org/apache/maven/surefire/surefire-shared-utils/3.0.0-M6-SNAPSHOT/
   total 3040
   ...      232 Jan  8 18:37 _remote.repositories
   ...      741 Jan  8 18:37 maven-metadata-local.xml
   ...  1543867 Jan  8 18:37 surefire-shared-utils-3.0.0-M6-SNAPSHOT.jar
   ...      503 Jan  8 18:37 surefire-shared-utils-3.0.0-M6-SNAPSHOT.pom
   
   $ ls -l ~/.m2/repository-prv/org/apache/maven/surefire/surefire-shared/3.0.0-M6-SNAPSHOT/
   total 3088
   ...      408 Jan  8 18:37 _remote.repositories
   ...     1497 Jan  8 18:37 maven-metadata-local.xml
   ...     7127 Jan  8 18:37 surefire-shared-3.0.0-M6-SNAPSHOT-sources.jar
   ...      866 Jan  8 18:37 surefire-shared-3.0.0-M6-SNAPSHOT-sources.jar.asc
   ...  1543867 Jan  8 18:37 surefire-shared-3.0.0-M6-SNAPSHOT.jar
   ...      866 Jan  8 18:37 surefire-shared-3.0.0-M6-SNAPSHOT.jar.asc
   ...     5386 Jan  8 18:37 surefire-shared-3.0.0-M6-SNAPSHOT.pom
   ...      866 Jan  8 18:37 surefire-shared-3.0.0-M6-SNAPSHOT.pom.asc
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] slawekjaranowski commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1007231317






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1006177608


   @slawekjaranowski
   This looks much better. Please have a look at the second commit. Can I squash it, rebase and merge?
   https://github.com/apache/maven-surefire/pull/426/commits/f38a4851d08d746fea39707a7ae37ff1181431f6


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1013480046


   @slawekjaranowski
   @michael-o
   I found a good way with classifiers and I worked around the IDEA issue with a small trick using profile. Meanwhile see this [bug ](https://youtrack.jetbrains.com/issue/IDEA-148573) in Jetbrains. Closing in favor of #443, I think you would be very happy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] slawekjaranowski commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1008172135


   We will not have signature for additional artifact.
   
   `gpg` is executet in `verify` phase
   `install-jar` is bind by you to `install` phase
   
   I don't know what restrictions are for AFS releases ... but for oss by Sonatype each artifact must have signature
   
   Profile apache-release can be used for test, we see what will happen during release


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1012454171


   As I spoke with Michael. I guess the m-exec-p would help us solve all these issues, the Maven project would build the far jar as it should and the IntelliJ IDEA would see the shaded artifact. It is my hypothesis, we can confirm it in a new commit, let;s see...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1003791250


   @slawekjaranowski
   @eolivelli
   I will try to make one more alternative without these ugly plugins (install, deploy, build-helper) similar to what we had several years ago with several exceptions that now the external classes will not be included/duplicate in all JAR files and the `surefire-shared-utils` artifact will exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1008045131


   @slawekjaranowski Well it should be signed, we can check it out but the snapshot deployments worked.
   I need to go offline for an hour but then I would try this...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1008157885


   I made it working ;-)
   But the profile `apache-release` is not dedicated for SNAPSHOTS. Only for releases.
   Yeah, I had to turn `distributionManagement.repository.id` to `distributionManagement.snapshotRepository.id` but it is done to confirm that the GnuPG plugin works as well.
   See the `maven-release-plugin` in the ASF parent. The plugin activates the `apache-release` profile with gpg, javadoc, sources plugins, etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1006163662


   @slawekjaranowski
   This might be even possible with a classifier. Let me check it out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1006497912


   @slawekjaranowski 
   Open this branch in IDEA and you will see red lines. The IDEA does not understand the classifiers. Additionally surefire-booter hangs, I did not have time to have a look yet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] michael-o commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1012427336


   Will check this in the next couple of days. This is maybe 50 shades of Maven.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] slawekjaranowski commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1006430587


   looks very good .. go ahead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] slawekjaranowski commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1007231575


   We are trying many complicated way to build this artifact ... 
   I start thinking about remove it and use shade-plugin in final modules - it will be more clear. 
   We can use shade-plugin with minimizeJar 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1006964448


   @slawekjaranowski
   
   I was able to avoid  `build-helper-maven-plugin` and use the trick with setting properties (`distRepoId`, `distRepoUrl`) for snapshots by default and for release as well. The other two plugins could not be avoided. This works fine with IntelliJ IDEA/ Eclipse. The solution previously used with a classifier did not work with IDEA - red lines in the import section and hanging tests in the module `surefire-booter`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1012337760


   @slawekjaranowski
   We can add the following section into project POM with identical plugin execution ID for some temporal time but the ideal situation would be to do it in the parent POM `org.apache:apache`. Currently, the `maven-gpg-plugin` appears within the profile `apache-release` in the parent POM and it means that somebody should extract GPG plugin and move it to build/plugins section from the profile section and then it would conform with Sonatype.
   
   ```
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-gpg-plugin</artifactId>
               <executions>
                 <execution>
                   <id>sign-release-artifacts</id>
                   <goals>
                     <goal>sign</goal>
                   </goals>
                 </execution>
               </executions>
             </plugin>
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1013125740


   Both alternatives (last two commits) have some disadvantages.
   646b38f = has no notion of maven-parent POM.
   0b2bed9 = red lines in the code
   As I spoke with Karl, he told me some long time ago, that referencing some version like nowadays 3.0.0-M5 is fine. Next time we have to thing in advance and prepare the upgrades for the next version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426#issuecomment-1012454171


   As I spoke with Michael. I guess the m-exec-p would help us solve all these issues, the Maven project would build the far jar as it should and the IntelliJ IDEA would see the shaded artifact.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [maven-surefire] Tibor17 closed pull request #426: [SUREFIRE-1972] Use current version of surefire-shared-utils

Posted by GitBox <gi...@apache.org>.
Tibor17 closed pull request #426:
URL: https://github.com/apache/maven-surefire/pull/426


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org