You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2024/12/20 07:42:52 UTC
[I] Configure environments for publishing [airflow-publish]
potiuk opened a new issue, #10:
URL: https://github.com/apache/airflow-publish/issues/10
We need to have [environments](https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-deployments/managing-environments-for-deployment) configured as this is recommended best practice, becuse we should only have a handful of people (release manager) capable of publishig the releases, and this environment should be very separate and allow to only execute publishing workflows.
This however requires changes to [.asf.yaml](https://github.com/apache/infrastructure-asfyaml) as we should be able to configure such environments via .asf.yaml file.
Currently .asf.yaml does not have the capability of configuring environments, but it should be rather straightforward to contribute changes to the .asf.yaml [processing python script ](https://github.com/apache/infrastructure-p6/blob/production/modules/gitbox/files/asfgit/package/asfyaml.py) to include it, because there is [API available](https://docs.github.com/en/rest/deployments/environments?apiVersion=2022-11-28) to manage the environments and we should be able to contribute it rather easily.
I already contributed once there https://github.com/apache/infrastructure-p6/commit/21b98e56ef7cd9c62fa20ec5b6aef008fb342971 - and we can again contribute back to the ASF and make it possible for all projects to configure environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2558444638
👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2825193602
> Go ahead if you want (or maybe I missed it?
No nothing major, planning to make these actions ready for `infrastructure-actions` repo and instead of summary action, will add small util file that can be imported easily in all actions so easy to use. otherwise summary action needs to be called always :) WDYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2558088913
Looks great. I would vote for environments. Less is more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2556516087
> cc: @gopidesupavan -> maybe you would like to take a look at that - that would be a nice contribution not only for the Apache Airflow but eventually for the whole Apache Software Foundation and infrastructure of it.
Yeah will have a look :) thanks for sharing the references
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2556525638
> BTW. @gopidesupavan -> do you have account on the ASF JIRA (https://issues.apache.org/j) ? We will need to interact with Infra in the course of this project, so you will need one :)
Sure wi
> https://issues.apache.org/j
Just checked yeah i have access to jira :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2812388641
Yeah off-course :) , meantime i am planning tweak the actions if there are any improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2888471999
Needs workflow modifications next steps , based on svn dist structure i can modify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2889283186
cool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2812374099
@potiuk we should be able to test this now , PR merged to asfyml repo :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2558440238
> Looks great. I would vote for environments. Less is more
Raised pr here https://github.com/apache/infrastructure-p6/pull/2020 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2556532061
What Account id ? - we have that issue in INFRA where we discuss it so I can add you to it https://issues.apache.org/jira/browse/INFRA-24678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2556454950
cc: @gopidesupavan -> maybe you would like to take a look at that - that would be a nice contribution not only for the Apache Airflow but eventually for the whole Apache Software Foundation and infrastructure of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2888471462
@potiuk the environments has been created :) verified with gh api.
`gh api -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" /repos/apache/airflow-publish/environments`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2825133117
Go ahead if you want (or maybe I missed it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2812378607
Fantastic! Once the AF 3 frenzy is done - we should do it - for Airflow 3.0.1+ releases. I do not want to mess aroiund with our processes now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2558082638
Got understand of code base to update asf yml. i am thinking of this yml structure WDYT? :)
```
environments:
test-pypi:
required_reviewers:
- reviewer1
- reviewer2
prevent_self_review: true
wait_timer: 1
deployment_branch_policy:
protected_branches: true
custom_branch_policies: false
pypi:
required_reviewers:
- reviewer1
- reviewer2
prevent_self_review: true
wait_timer: 1
deployment_branch_policy:
protected_branches: false
custom_branch_policies: true
policies:
- name: main
type: branch
- name: 1.0.0
type: tag
- name: "release/*/*"
```
Policies is required to create only when choose `custom_branch_policies` so basically , each deployment environment can have multiple custom policies or choose `protected_branches`
not sure which root element is better `environments:` or `deployment_environments: ` :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2556460851
BTW. @gopidesupavan -> do you have account on the ASF JIRA (https://issues.apache.org/j) ? We will need to interact with Infra in the course of this project, so you will need one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Configure environments for publishing [airflow-publish]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on issue #10:
URL: https://github.com/apache/airflow-publish/issues/10#issuecomment-2556534065
> What Account id ? - we have that issue in INFRA where we discuss it so I can add you to it https://issues.apache.org/jira/browse/INFRA-24678
gopidesu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org